Skip to content

have AzureKeyCredentialPolicy accept and ignore kwargs #11963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscai-msft merged 4 commits into from
Jun 11, 2020
Merged

have AzureKeyCredentialPolicy accept and ignore kwargs #11963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41bd496
have AzureKeyCredentialPolicy accept and ignore kwargs
iscai-msft Jun 10, 2020
9c1bf10
fix pylint
iscai-msft Jun 11, 2020
0784d0b
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
iscai-msft Jun 11, 2020
151a4df
updated changelog
iscai-msft Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/core/azure-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

## 1.6.1 (Unreleased)

### Bug fixes

- `AzureKeyCredentialPolicy` will now accept (and ignore) passed in kwargs #11963

## 1.6.0 (2020-06-03)

Expand Down
4 changes: 2 additions & 2 deletions sdk/core/azure-core/azure/core/pipeline/policies/_authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ class AzureKeyCredentialPolicy(SansIOHTTPPolicy):
:param str name: The name of the key header used for the credential.
:raises: ValueError or TypeError
"""
def __init__(self, credential, name):
# type: (AzureKeyCredential, str) -> None
def __init__(self, credential, name, **kwargs): # pylint: disable=unused-argument
# type: (AzureKeyCredential, str, Any) -> None
super(AzureKeyCredentialPolicy, self).__init__()
self._credential = credential
if not name:
Expand Down