Skip to content

Test azure-identity using msal dev build #12247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkuttappan merged 3 commits into from
Jul 7, 2020
Merged

Test azure-identity using msal dev build #12247

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fedd954
Test identity using MSAL dev version
praveenkuttappan Jun 27, 2020
e5dc973
Remove CI and PR triggers for msal dev build test pipeline
praveenkuttappan Jun 30, 2020
cafe0a6
Remove CI and PR triggers for msal dev build test pipeline
praveenkuttappan Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sdk/identity/msal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

trigger: none
pr: none

extends:
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: identity
InjectedPackages: 'git+https://github.com/AzureAD/microsoft-authentication-library-for-python@dev'

@weshaggard weshaggard Jun 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to make this it's own pipeline as opposed to a matrix entry in the existing pipeline?

@praveenkuttappan praveenkuttappan Jun 30, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't want to run this step as part of every PR or CI and run just once as scheduled. Second point was to avoid msal breakage being a roadblock for any change in azure-identity side. Adding @chlowell for any additional comments.

@weshaggard weshaggard Jun 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is similar in nature to https://github.com/Azure/azure-sdk-for-python/blob/master/eng/pipelines/templates/jobs/tests-nightly-python.yml where we are doing some validation on a schedule but not really blocking anything on it. If so do we have a plan for who will monitor the failures?

@chlowell chlowell Jun 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we want to catch a breaking change (from the perspective of our expectations) in MSAL's dev branch before it ships. There's no need to run this on our PRs, or more often than daily. It's another nightly job and I'm happy to get email when it fails, as I do for the nightly live run.

Artifacts:
- name: azure_identity
safeName: azureidentity