commit metrics advisor - #14072
Merged
Merged
Conversation
xiangyan99
marked this pull request as ready for review
September 28, 2020 19:54
xiangyan99
requested review from
lmazuel,
mayurid and
mitchdenny
as code owners
September 28, 2020 19:54
kristapratico
left a comment
kristapratico
left a comment
Contributor
There was a problem hiding this comment.
We're missing changes in:
allowed_pylint_failures.py (although I'm working on this right now so will be able to remove shortly)
Can we keep the transform file? https://github.com/Azure/azure-sdk-for-python-pr/blob/60e7b2671792171874da4ba8139fa8e9dee43503/sdk/metricsadvisor/azure-ai-metricsadvisor/swagger/pythonREADME.md
Member
Author
|
--> in terms of transform file. Yes. But now "input-file: ./metricsadvisor_1.20200917_openapi.v2.json" is incorrect. Let's add it when it is officially published. |
xiangyan99
requested review from
danieljurek,
scbedd and
weshaggard
as code owners
September 28, 2020 20:13
kristapratico
previously approved these changes
Sep 28, 2020
kristapratico
approved these changes
Sep 28, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Sep 29, 2020
…into path_format_args_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (46 commits) Fix typo in track 2 migration guide (Azure#14006) commit metrics advisor (Azure#14072) [eventgrid] Update README.md (Azure#14030) Update Key Vault readmes (Azure#14068) Update CODEOWNERS (Azure#14054) Correct azure-eventhub example (Azure#14050) Replace docstring code blocks with literalincludes (Azure#13948) Added more docstring context and sample code for `receive_messages()` (Azure#13789) Form 2.1-preview.1 (Azure#13770) Sync eng/common directory with azure-sdk-tools repository for Tools PR 1029 (Azure#13896) Service Mapping Update for Communication (Azure#13979) update sample to show facet+count & collection type (Azure#13909) Increment package version after release of azure_eventgrid (Azure#14020) Update CHANGELOG.md (Azure#14014) fixed delete blob types (Azure#14001) Fixed issues with resource token (Azure#13855) update samples and readme (Azure#13999) update dependent version of azure-core (Azure#13986) Sync eng/common directory with azure-sdk-tools repository for Tools PR 1041 (Azure#14005) Track2-azure-mgmt-baremetalinfrastructure-2020-9-22 (Azure#13941) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.