[Service Bus] Deprecate Internal _Accesstoken

[egelfand]

Replaced references to internal _Accesstoken with the Accesstoken itself, now that its available. Closes #13638.

[ghost]

Thank you for your contribution egelfand! We will review the pull request and get back to you soon.

[KieranBrantnerMagee]

I don't know if you're able to view the CI output so I've pasted the current exception below, should be a simple fix (just addressing the async import for this same stanza) otherwise this approach looks solid.

ImportError while importing test module '/home/vsts/work/1/s/sdk/servicebus/azure-servicebus/tests/async_tests/test_sessions_async.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: tests/async_tests/test_sessions_async.py:17: in <module> from azure.servicebus.aio import ServiceBusClient, ReceivedMessage, AutoLockRenew azure/servicebus/aio/__init__.py:7: in <module> from ._servicebus_sender_async import ServiceBusSender azure/servicebus/aio/_servicebus_sender_async.py:14: in <module> from ._base_handler_async import BaseHandler azure/servicebus/aio/_base_handler_async.py:17: in <module> from .._base_handler import _generate_sas_token, _AccessToken, BaseHandler as BaseHandlerSync E ImportError: cannot import name '_AccessToken' from 'azure.servicebus._base_handler' (/home/vsts/work/1/s/sdk/servicebus/azure-servicebus/azure/servicebus/_base_handler.py)

[ghost]

All CLA requirements met.

[yunhaoling]

hey @egelfand , thanks for the PR :) we're very close to merging it with just three minor mypy/pylint issue:

mypy is reporting:

azure/servicebus/_base_handler.py:96: error: Name '_AccessToken' is not defined
azure/servicebus/_base_handler.py:150: error: Name '_AccessToken' is not defined

action: _AccessToken -> AccessToken

pylint is reporting:

azure/servicebus/_base_handler.py:5: [W0611(unused-import), ] Unused import collections

action: we could simply remove the import

I'm sure CI would be happy after we apply the changes, then we could approve and merge the PR.

[yunhaoling]

/azp run python - servicebus - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yunhaoling]

hey @egelfand, your PR looks good to me, could you sign the agreement mentioned by microsoft-cla:
#14450 (comment)

so that we could merge your PR.

[egelfand]

Just did so, thanks for all of your help!

[yunhaoling]

thanks for the contribution!