[Tables] Cosmos workaround for Merge/Update - #17888
Merged
13 commits merged intoApr 8, 2021
Merged
Conversation
annatisch
reviewed
Apr 8, 2021
annatisch
left a comment
annatisch
left a comment
Member
There was a problem hiding this comment.
Looking good - thanks for this!
| assert transaction_result.get_entity('batch_all_operations_together-2') is not None | ||
| assert transaction_result.get_entity('batch_all_operations_together-3') is not None | ||
| assert transaction_result.get_entity('batch_all_operations_together-4') is not None | ||
| assert transaction_result.get_entity('batch_all_operations_together-5') is not None |
Member
There was a problem hiding this comment.
I'm wondering if we should rename this method - it's a bit too close to client.get_entity.
I'll have a think about this one :)
annatisch
approved these changes
Apr 8, 2021
annatisch
left a comment
annatisch
left a comment
Member
There was a problem hiding this comment.
Looks good :)
Maybe add a note to the changelog?
|
Hello @seankane-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13844