Skip to content

[EngSys] updating the delete methods #18304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Laurent Mazuel (lmazuel) merged 3 commits into from
Jul 6, 2021
Merged

[EngSys] updating the delete methods #18304

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cea9d45
updating the delete methods
seankane-msft Apr 26, 2021
6a857a3
moving logging statement
seankane-msft Apr 27, 2021
b295db2
breaking out into method
seankane-msft Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tools/azure-sdk-tools/devtools_testutils/resource_testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ def __init__(
self.set_cache(use_cache, parameter_name, name_prefix)
self.delete_after_tag_timedelta = delete_after_tag_timedelta

def _prefix_name(self, name):
name = u"rgpy-" + name
if len(name) > 90:
name = name[:90]
return name

def create_resource(self, name, **kwargs):
if self.is_live and self._need_creation:
self.client = self.create_mgmt_client(ResourceManagementClient)
Expand All @@ -75,13 +81,11 @@ def create_resource(self, name, **kwargs):
parameters["tags"]["BuildNumber"] = os.environ.get("BUILD_BUILDNUMBER", "local")
parameters["tags"]["BuildReason"] = os.environ.get("BUILD_REASON", "local")
try:
# Prefixing all RGs created here with 'rgpy-' for tracing purposes
name = self._prefix_name(name)
logging.info(
"Attempting to create a Resource Group with name {} and parameters {}".format(name, parameters)
)
# Prefixing all RGs created here with 'rgpy-' for tracing purposes
name = u"rgpy-" + name
if len(name) > 90:
name = name[:90]
self.resource = self.client.resource_groups.create_or_update(name, parameters)
except Exception as ex:
if "ReservedResourceName" in str(ex):
Expand All @@ -101,6 +105,7 @@ def create_resource(self, name, **kwargs):

def remove_resource(self, name, **kwargs):
if self.is_live and self._need_creation:
name = self._prefix_name(name)
try:
if "wait_timeout" in kwargs:
azure_poller = self.client.resource_groups.begin_delete(name)
Expand Down