[Blob][STG78]Object Imutability Policy (Version Level Worm) by xiafu-msft · Pull Request #19098 · Azure/azure-sdk-for-python

Xiaoxi Fu (xiafu-msft) · 2021-06-04T03:45:09Z

No description provided.

Gauri Lamunion (gapra-msft)

public API looks good. Please ask Kamil about the bundled vs unbundled immutabilitypolicy stuff

Xiaoxi Fu (xiafu-msft) · 2021-07-19T23:19:52Z

+        :keyword ~datetime.datetime immutability_policy_expiry_time:
+            Specifies the date time when the blobs immutability policy is set to expire.
+        :keyword immutability_policy_mode:
+            Specifies the immutability policy mode to set on the blob.
+        :paramtype immutability_policy_mode: ~azure.storage.blob.BlobImmutabilityPolicyMode or str


Hi Kamil Sobol (@kasobol-msft) I think we need your thoughts here.
Gauri Gauri Lamunion (@gapra-msft) and I were discussing about these two parameters. For Java and .Net these two parameters are grouped into a class called BlobImmutabilityPolicy, while in Python we don't have the overloading concern so usually we just list the parameters. Do you have any thoughts? Should we keep it consistent with Java and .Net or leave it like this?
Also Anna suggested to rename these two parameters to expiry and mode, and I put the reason why I haven't renamed them yet https://apiview.dev/Assemblies/Review/266426541eba45098d08bbddfb5ce8ac/7977909c50af4022868fd86d76bbc17c#azure.storage.blob.aio.BlobClient.set_immutability_policy:async.param(immutability_policy_mode

Thanks for your input!

I'd group them together in both places. (we seem to do this from time to time for inputs that belong together

azure-sdk-for-python/sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

Lines 538 to 540 in a65e853

:keyword ~azure.storage.blob.ContentSettings content_settings:

ContentSettings object used to set blob properties. Used to set content type, encoding,

language, disposition, md5, and cache control.

)

We can group them together just some params are not grouped together and they are all for conditional match

azure-sdk-for-python/sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

Lines 514 to 530 in a65e853

:keyword ~datetime.datetime if_modified_since:

A DateTime value. Azure expects the date value passed in to be UTC.

If timezone is included, any non-UTC datetimes will be converted to UTC.

If a date is passed in without timezone info, it is assumed to be UTC.

Specify this header to perform the operation only

if the resource has been modified since the specified time.

:keyword ~datetime.datetime if_unmodified_since:

A DateTime value. Azure expects the date value passed in to be UTC.

If timezone is included, any non-UTC datetimes will be converted to UTC.

If a date is passed in without timezone info, it is assumed to be UTC.

Specify this header to perform the operation only if

the resource has not been modified since the specified date/time.

:keyword str etag:

The destination ETag value, or the wildcard character (*). Used to check if the resource has changed,

and act according to the condition specified by the `match_condition` parameter.

:keyword ~azure.core.MatchConditions match_condition:

The destination match condition to use upon the etag.

Xiaoxi Fu (xiafu-msft) · 2021-07-22T17:56:41Z

/azp run storage - python - tests

azure-pipelines · 2021-07-22T17:56:45Z

No pipelines are associated with this pull request.

Xiaoxi Fu (xiafu-msft) · 2021-07-22T17:57:25Z

/azp run python - storage - tests

azure-pipelines · 2021-07-22T17:57:31Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

* [Blob][STG78]Object Imutability Policy (Version Level Worm)

* generated from swaggers * new support service versions * regenrated * [STG78] Added Quick Query Parquet Dialect (#18904) * Added Quick Query Dialect * fixed ci * fix ci path * anna comments * removed parquet type * reverted versions * reverted versions * fixed dep * [Blob][STG78]List Deleted Root Blob with Versions (#19097) * [Blob][STG78]List Deleted Root Blob with Versions * Update test_container_async.py * [STG78] Copy Source OAuth Token Support (#18998) * OAuth Copy Source Support * added tokens to blob client * added support in file client * Added tests * regenerated * Added sync tests and renamed param * added some async tests * removed import and fixed desc and validation * added more tests * remove import * fixed ci * [Blob][STG78]Object Imutability Policy (Version Level Worm) (#19098) * [Blob][STG78]Object Imutability Policy (Version Level Worm) * [STG78][FileShare]List Files v2 (#19017) * [STG78][FileShare]List Files v2 * fix pylint * fix live test Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com> Co-authored-by: xiafu <xiafu@microsoft.com>

[Blob][STG78]Object Imutability Policy (Version Level Worm)

3ffabe6

Xiaoxi Fu (xiafu-msft) requested review from Ashish Mishra (amishra-dev), Anna Tisch (annatisch), Kamil Sobol (kasobol-msft), Tamer (tasherif-msft) and Ze Qian Zhang (zezha-msft) as code owners June 4, 2021 03:45

ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 4, 2021

Xiaoxi Fu (xiafu-msft) added 3 commits June 4, 2021 10:54

edit import mgmt plane models

90b6c9a

fix doc pylint dependencies

3939a3f

fix test

aa14b21

Tamer (tasherif-msft) approved these changes Jul 7, 2021

View reviewed changes

Xiaoxi Fu (xiafu-msft) and others added 3 commits July 19, 2021 13:49

Merge branch 'feature/storage-stg78' into vlw

261986c

rename immutability_policy permission

c581de0

rename legal_hold

86b677f

Gauri Lamunion (gapra-msft) approved these changes Jul 19, 2021

View reviewed changes

Xiaoxi Fu (xiafu-msft) commented Jul 19, 2021

View reviewed changes

Xiaoxi Fu (xiafu-msft) and others added 6 commits July 19, 2021 17:41

Update _deserialize.py

c2d9026

rename legal_hold

197c339

rename legal_hold

2593525

Create ImmutabilityPolicy class

8dea092

consume BlobAccountPreparer

880758c

add import

1611deb

Kamil Sobol (kasobol-msft) approved these changes Jul 22, 2021

View reviewed changes

Xiaoxi Fu (xiafu-msft) added 2 commits July 22, 2021 12:00

fix import

859208a

fix tests

9cb1d56

Xiaoxi Fu (xiafu-msft) closed this Jul 22, 2021

Xiaoxi Fu (xiafu-msft) reopened this Jul 22, 2021

Xiaoxi Fu (xiafu-msft) merged commit ed1b036 into Azure:feature/storage-stg78 Jul 22, 2021

Xiaoxi Fu (xiafu-msft) added a commit that referenced this pull request Jul 27, 2021

[Blob][STG78]Object Imutability Policy (Version Level Worm) (#19098)

2e97f30

* [Blob][STG78]Object Imutability Policy (Version Level Worm)

Navigation Menu

Uh oh!

[Blob][STG78]Object Imutability Policy (Version Level Worm) - #19098

[Blob][STG78]Object Imutability Policy (Version Level Worm)#19098
Xiaoxi Fu (xiafu-msft) merged 15 commits into
Azure:feature/storage-stg78from
xiafu-msft:vlw

Xiaoxi Fu (xiafu-msft) commented Jun 4, 2021

Uh oh!

Gauri Lamunion (gapra-msft) left a comment

Uh oh!

Xiaoxi Fu (xiafu-msft) Jul 19, 2021

Uh oh!

Kamil Sobol (kasobol-msft) Jul 20, 2021

Uh oh!

Xiaoxi Fu (xiafu-msft) Jul 20, 2021

Uh oh!

Xiaoxi Fu (xiafu-msft) commented Jul 22, 2021

Uh oh!

azure-pipelines Bot commented Jul 22, 2021

Uh oh!

Xiaoxi Fu (xiafu-msft) commented Jul 22, 2021

Uh oh!

azure-pipelines Bot commented Jul 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	:keyword ~azure.storage.blob.ContentSettings content_settings:
	ContentSettings object used to set blob properties. Used to set content type, encoding,
	language, disposition, md5, and cache control.

	:keyword ~datetime.datetime if_modified_since:
	A DateTime value. Azure expects the date value passed in to be UTC.
	If timezone is included, any non-UTC datetimes will be converted to UTC.
	If a date is passed in without timezone info, it is assumed to be UTC.
	Specify this header to perform the operation only
	if the resource has been modified since the specified time.
	:keyword ~datetime.datetime if_unmodified_since:
	A DateTime value. Azure expects the date value passed in to be UTC.
	If timezone is included, any non-UTC datetimes will be converted to UTC.
	If a date is passed in without timezone info, it is assumed to be UTC.
	Specify this header to perform the operation only if
	the resource has not been modified since the specified date/time.
	:keyword str etag:
	The destination ETag value, or the wildcard character (*). Used to check if the resource has changed,
	and act according to the condition specified by the `match_condition` parameter.
	:keyword ~azure.core.MatchConditions match_condition:
	The destination match condition to use upon the etag.

Uh oh!

Conversation

Xiaoxi Fu (xiafu-msft) commented Jun 4, 2021

Uh oh!

Gauri Lamunion (gapra-msft) left a comment

Choose a reason for hiding this comment

Uh oh!

Xiaoxi Fu (xiafu-msft) Jul 19, 2021

Choose a reason for hiding this comment

Uh oh!

Kamil Sobol (kasobol-msft) Jul 20, 2021

Choose a reason for hiding this comment

Uh oh!

Xiaoxi Fu (xiafu-msft) Jul 20, 2021

Choose a reason for hiding this comment

Uh oh!

Xiaoxi Fu (xiafu-msft) commented Jul 22, 2021

Uh oh!

azure-pipelines Bot commented Jul 22, 2021

Uh oh!

Xiaoxi Fu (xiafu-msft) commented Jul 22, 2021

Uh oh!

azure-pipelines Bot commented Jul 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants