First set of API review feedback

[Larry Osterman (LarryOsterman)]

This commit represents the first part of the Attestation Service API review. It includes the following changes:

• Removed the AttestationSigningKey type in favor of keyword arguments.
• Added a signing_key and signing_certificate parameter to the AttestationAdministrationClient class to simplify the API calling pattern for the policy APIs.
• Removed the TpmAttestationRequest and TpmAttestationResponse wrapper types.
• Converted all keys and certificates from DER encoded byte arrays to PEM encoded strings for consistency with other Azure APIs.
• Removed the AttestationResponse type; Consolidated the attestation policy responses to a single AttestationPolicyResult type.
• Removed the TokenValidationOptions type, consolidated into the various APIs as keyword args.

[check-enforcer]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

[Sean Kane (seankane-msft)]

Some preliminary feedback

[Sean Kane (seankane-msft)]

I would recommend using the black package to format your code or at least the samples. It will make it more readable for end-users. You can use

pip install black
cd sdk/attestation/azure-security-attestation
black . # or whatever directory ie black . samples/
git checkout -- azure/security/attestation/_generated  # dont want to apply to generated code.

[Larry Osterman (LarryOsterman)]

I would recommend using the black package to format your code or at least the samples. It will make it more readable for end-users. You can use

pip install black
cd sdk/attestation/azure-security-attestation
black . # or whatever directory ie black . samples/
git checkout -- azure/security/attestation/_generated  # dont want to apply to generated code.

I don't know if it matters, but the JS SDK and REST API SDK both run prettier on the checked in code and fail the CI process if the code doesn't match. It might make sense to do the same for Python, assuming that black generates canonically valid code.

[Laia Patiño (laiapat)]

Things are looking really good! I think these are the only remaining things that I've noticed

[Laia Patiño (laiapat)]

Thank you for all the work on this!

[Larry Osterman (LarryOsterman)]

/azp run python - attestation - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).