Remaining Hardcoded to master items - #19331
Merged
Scott Beddall (scbedd) merged 1 commit intoJun 18, 2021
Merged
Conversation
Scott Beddall (scbedd)
requested review from
Cassius Smith (RAY-316) and
Yuchao Yan (msyyc)
as code owners
June 18, 2021 16:19
Chidozie Ononiwu (chidozieononiwu)
approved these changes
Jun 18, 2021
Member
Author
|
/azp run python - core - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Member
Author
|
Attempting an internal run as well. |
Member
Author
|
/azp run python - appconfiguration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - containerregistry - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| else: | ||
| with open(f'{OUT_PATH}/output.txt', 'w') as file_out: | ||
| file_out.writelines([f'{NEW_BRANCH}\n', "master" if TRACK == '2' else 'release/v3']) | ||
| file_out.writelines([f'{NEW_BRANCH}\n', "main" if TRACK == '2' else 'release/v3']) |
Member
Author
There was a problem hiding this comment.
Yuchao Yan (@msyyc) please yell at me if this is an improper update. Given the context of this issue I think we're fine. Please correct me if I'm wrong!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of this issue