Skip to content

[Key Vault] Add 7.3-preview and random bytes API - #19468

Merged
Laia Patiño (laiapat) merged 11 commits into
Azure:mainfrom
laiapat:73-preview-rebased
Jul 7, 2021
Merged

[Key Vault] Add 7.3-preview and random bytes API#19468
Laia Patiño (laiapat) merged 11 commits into
Azure:mainfrom
laiapat:73-preview-rebased

Conversation

@laiapat

@laiapat Laia Patiño (laiapat) commented Jun 24, 2021

Copy link
Copy Markdown
Member

Resolves #19577. This adds the 7.3-preview API version, but doesn't include SKR at this time.

This skips 7.3-preview testing for a handful of test cases that require key import. These are currently blocked on an issue with key import on 7.3-preview on Key Vault.

@laiapat Laia Patiño (laiapat) added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 24, 2021

@heaths Heath Stewart (heaths) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-generated source and supporting files LGTM

Comment thread sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_version.py
Comment thread sdk/keyvault/azure-keyvault-keys/tests/_test_case.py Outdated
@check-enforcer

check-enforcer Bot commented Jul 7, 2021

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@laiapat
Laia Patiño (laiapat) marked this pull request as ready for review July 7, 2021 18:37
@laiapat
Laia Patiño (laiapat) merged commit 4134479 into Azure:main Jul 7, 2021
@laiapat
Laia Patiño (laiapat) deleted the 73-preview-rebased branch July 7, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Key Vault] Support get_random_bytes method in keys

3 participants