Skip to content

add aad support - #19604

Merged
Xiang Yan (xiangyan99) merged 4 commits into
mainfrom
search_aad
Jul 1, 2021
Merged

add aad support#19604
Xiang Yan (xiangyan99) merged 4 commits into
mainfrom
search_aad

Conversation

@xiangyan99

Copy link
Copy Markdown
Member

No description provided.

@ghost ghost added the Search label Jun 30, 2021
@xiangyan99
Xiang Yan (xiangyan99) marked this pull request as ready for review June 30, 2021 19:54
return status_code in [422, 409, 503]

def get_authentication_policy(credential):
authentication_policy = policies.BearerTokenCredentialPolicy(credential, CREDENTIAL_SCOPES)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible that a user might want to pass their own scopes? For different clouds, e.g. govt or mooncake? Wondering if scopes should be a kwarg

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now (at least in this preview), no. It is hard-coded by the search team.

@xiangyan99
Xiang Yan (xiangyan99) merged commit 32e2114 into main Jul 1, 2021
@xiangyan99
Xiang Yan (xiangyan99) deleted the search_aad branch July 1, 2021 18:10
Rakshith Bhyravabhotla (rakshith91) pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Aug 10, 2022
* add aad support

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants