Skip to content

renaming #19630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xiang Yan (xiangyan99) merged 2 commits into from
Jul 2, 2021
Merged

renaming #19630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7336993
renaming
xiangyan99 Jul 1, 2021
8e7ddb5
Update sdk/metricsadvisor/azure-ai-metricsadvisor/azure/ai/metricsadv…
xiangyan99 Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/metricsadvisor/azure-ai-metricsadvisor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
- `AnomalyAlert.created_on` -> `AnomalyAlert.created_time`
- `AnomalyAlert.modified_on` -> `AnomalyAlert.modified_time`
- `Anomaly.created_on` -> `Anomaly.created_time`
- `admin_emails` has been renamed to `admins` in `NotificationHook`
- `admin_emails` has been renamed to `admins` in `DataFeedOptions`
- `viewer_emails` has been renamed to `viewers` in `DataFeedOptions`

## 1.0.0b4 (2021-06-07)

Expand Down
12 changes: 6 additions & 6 deletions sdk/metricsadvisor/azure-ai-metricsadvisor/azure/ai/metricsadvisor/_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ def convert_to_generated_data_feed_type(
granularity,
schema,
ingestion_settings,
admin_emails=None,
admins=None,
data_feed_description=None,
missing_data_point_fill_settings=None,
rollup_settings=None,
viewer_emails=None,
viewers=None,
access_mode=None,
action_link_template=None
):
Expand All @@ -135,15 +135,15 @@ def convert_to_generated_data_feed_type(
:type schema: ~azure.ai.metricsadvisor.models.DataFeedSchema
:param ingestion_settings: The data feed ingestions settings
:type ingestion_settings: ~azure.ai.metricsadvisor.models.DataFeedIngestionSettings
:param list[str] admin_emails: Data feed administrator emails.
:param list[str] admins: Data feed administrators.
:param str data_feed_description: Data feed description.
:param missing_data_point_fill_settings: The fill missing point type and value.
:type missing_data_point_fill_settings:
~azure.ai.metricsadvisor.models.DataFeedMissingDataPointFillSettings
:param rollup_settings: The rollup settings.
:type rollup_settings:
~azure.ai.metricsadvisor.models.DataFeedRollupSettings
:param list[str] viewer_emails: Data feed viewer emails.
:param list[str] viewers: Data feed viewers.
:param access_mode: Data feed access mode. Possible values include:
"Private", "Public". Default value: "Private".
:type access_mode: str or ~azure.ai.metricsadvisor.models.DataFeedAccessMode
Expand Down Expand Up @@ -197,9 +197,9 @@ def convert_to_generated_data_feed_type(
if missing_data_point_fill_settings else None,
fill_missing_point_value=missing_data_point_fill_settings.custom_fill_value
if missing_data_point_fill_settings else None,
viewers=viewer_emails,
viewers=viewers,
view_mode=access_mode,
admins=admin_emails,
admins=admins,
action_link_template=action_link_template
)

Expand Down
20 changes: 10 additions & 10 deletions ...azure-ai-metricsadvisor/azure/ai/metricsadvisor/_metrics_advisor_administration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,15 +295,15 @@ def create_data_feed(
:param ingestion_settings: The data feed ingestions settings. Can be passed as a datetime to use for the
ingestion begin time or as a DataFeedIngestionSettings object if additional configuration is needed.
:type ingestion_settings: Union[~datetime.datetime, ~azure.ai.metricsadvisor.models.DataFeedIngestionSettings]
:keyword list[str] admin_emails: Data feed administrator emails.
:keyword list[str] admins: Data feed administrators.
:keyword str data_feed_description: Data feed description.
:keyword missing_data_point_fill_settings: The fill missing point type and value.
:paramtype missing_data_point_fill_settings:
~azure.ai.metricsadvisor.models.DataFeedMissingDataPointFillSettings
:keyword rollup_settings: The rollup settings.
:paramtype rollup_settings:
~azure.ai.metricsadvisor.models.DataFeedRollupSettings
:keyword list[str] viewer_emails: Data feed viewer emails.
:keyword list[str] viewers: Data feed viewers.
:keyword access_mode: Data feed access mode. Possible values include:
"Private", "Public". Default value: "Private".
:paramtype access_mode: str or ~azure.ai.metricsadvisor.models.DataFeedAccessMode
Expand All @@ -322,11 +322,11 @@ def create_data_feed(
:caption: Create a data feed
"""

admin_emails = kwargs.pop('admin_emails', None)
admins = kwargs.pop('admins', None)
data_feed_description = kwargs.pop('data_feed_description', None)
missing_data_point_fill_settings = kwargs.pop('missing_data_point_fill_settings', None)
rollup_settings = kwargs.pop('rollup_settings', None)
viewer_emails = kwargs.pop('viewer_emails', None)
viewers = kwargs.pop('viewers', None)
access_mode = kwargs.pop('access_mode', "Private")
action_link_template = kwargs.pop('action_link_template', None)
data_feed_type = DATA_FEED[source.data_source_type]
Expand All @@ -337,11 +337,11 @@ def create_data_feed(
granularity=granularity,
schema=schema,
ingestion_settings=ingestion_settings,
admin_emails=admin_emails,
admins=admins,
data_feed_description=data_feed_description,
missing_data_point_fill_settings=missing_data_point_fill_settings,
rollup_settings=rollup_settings,
viewer_emails=viewer_emails,
viewers=viewers,
access_mode=access_mode,
action_link_template=action_link_template
)
Expand Down Expand Up @@ -762,9 +762,9 @@ def update_data_feed(
:paramtype fill_type: str or ~azure.ai.metricsadvisor.models.DatasourceMissingDataPointFillType
:keyword float custom_fill_value: The value of fill missing point for anomaly detection
if "CustomValue" fill type is specified.
:keyword list[str] admin_emails: Data feed administrator emails.
:keyword list[str] admins: Data feed administrators.
:keyword str data_feed_description: Data feed description.
:keyword list[str] viewer_emails: Data feed viewer emails.
:keyword list[str] viewers: Data feed viewers.
:keyword access_mode: Data feed access mode. Possible values include:
"Private", "Public". Default value: "Private".
:paramtype access_mode: str or ~azure.ai.metricsadvisor.models.DataFeedAccessMode
Expand Down Expand Up @@ -806,8 +806,8 @@ def update_data_feed(
update_kwargs["fillMissingPointType"] = kwargs.pop("fill_type", unset)
update_kwargs["fillMissingPointValue"] = kwargs.pop("custom_fill_value", unset)
update_kwargs["viewMode"] = kwargs.pop("access_mode", unset)
update_kwargs["admins"] = kwargs.pop("admin_emails", unset)
update_kwargs["viewers"] = kwargs.pop("viewer_emails", unset)
update_kwargs["admins"] = kwargs.pop("admins", unset)
update_kwargs["viewers"] = kwargs.pop("viewers", unset)
update_kwargs["status"] = kwargs.pop("status", unset)
update_kwargs["actionLinkTemplate"] = kwargs.pop("action_link_template", unset)
update_kwargs["dataSourceParameter"] = kwargs.pop("source", unset)
Expand Down
20 changes: 10 additions & 10 deletions ...etricsadvisor/azure/ai/metricsadvisor/aio/_metrics_advisor_administration_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,15 @@ async def create_data_feed(
:param ingestion_settings: The data feed ingestions settings. Can be passed as a datetime to use for the
ingestion begin time or as a DataFeedIngestionSettings object if additional configuration is needed.
:type ingestion_settings: Union[~datetime.datetime, ~azure.ai.metricsadvisor.models.DataFeedIngestionSettings]
:keyword list[str] admin_emails: Data feed administrator emails.
:keyword list[str] admins: Data feed administrators.
:keyword str data_feed_description: Data feed description.
:keyword missing_data_point_fill_settings: The fill missing point type and value.
:paramtype missing_data_point_fill_settings:
~azure.ai.metricsadvisor.models.DataFeedMissingDataPointFillSettings
:keyword rollup_settings: The rollup settings.
:paramtype rollup_settings:
~azure.ai.metricsadvisor.models.DataFeedRollupSettings
:keyword list[str] viewer_emails: Data feed viewer emails.
:keyword list[str] viewers: Data feed viewers.
:keyword access_mode: Data feed access mode. Possible values include:
"Private", "Public". Default value: "Private".
:paramtype access_mode: str or ~azure.ai.metricsadvisor.models.DataFeedAccessMode
Expand All @@ -221,11 +221,11 @@ async def create_data_feed(
:caption: Create a data feed
"""

admin_emails = kwargs.pop('admin_emails', None)
admins = kwargs.pop('admins', None)
data_feed_description = kwargs.pop('data_feed_description', None)
missing_data_point_fill_settings = kwargs.pop('missing_data_point_fill_settings', None)
rollup_settings = kwargs.pop('rollup_settings', None)
viewer_emails = kwargs.pop('viewer_emails', None)
viewers = kwargs.pop('viewers', None)
access_mode = kwargs.pop('access_mode', "Private")
action_link_template = kwargs.pop('action_link_template', None)
data_feed_type = DATA_FEED[source.data_source_type]
Expand All @@ -236,11 +236,11 @@ async def create_data_feed(
granularity=granularity,
schema=schema,
ingestion_settings=ingestion_settings,
admin_emails=admin_emails,
admins=admins,
data_feed_description=data_feed_description,
missing_data_point_fill_settings=missing_data_point_fill_settings,
rollup_settings=rollup_settings,
viewer_emails=viewer_emails,
viewers=viewers,
access_mode=access_mode,
action_link_template=action_link_template
)
Expand Down Expand Up @@ -663,9 +663,9 @@ async def update_data_feed(
:paramtype fill_type: str or ~azure.ai.metricsadvisor.models.DatasourceMissingDataPointFillType
:keyword float custom_fill_value: The value of fill missing point for anomaly detection
if "CustomValue" fill type is specified.
:keyword list[str] admin_emails: Data feed administrator emails.
:keyword list[str] admins: Data feed administrators.
:keyword str data_feed_description: Data feed description.
:keyword list[str] viewer_emails: Data feed viewer emails.
:keyword list[str] viewers: Data feed viewers.
:keyword access_mode: Data feed access mode. Possible values include:
"Private", "Public". Default value: "Private".
:paramtype access_mode: str or ~azure.ai.metricsadvisor.models.DataFeedAccessMode
Expand Down Expand Up @@ -707,8 +707,8 @@ async def update_data_feed(
update_kwargs["fillMissingPointType"] = kwargs.pop("fill_type", unset)
update_kwargs["fillMissingPointValue"] = kwargs.pop("custom_fill_value", unset)
update_kwargs["viewMode"] = kwargs.pop("access_mode", unset)
update_kwargs["admins"] = kwargs.pop("admin_emails", unset)
update_kwargs["viewers"] = kwargs.pop("viewer_emails", unset)
update_kwargs["admins"] = kwargs.pop("admins", unset)
update_kwargs["viewers"] = kwargs.pop("viewers", unset)
update_kwargs["status"] = kwargs.pop("status", unset)
update_kwargs["actionLinkTemplate"] = kwargs.pop("action_link_template", unset)
update_kwargs["dataSourceParameter"] = kwargs.pop("source", unset)
Expand Down
Loading