Skip to content

Sync eng/common directory with azure-sdk-tools for PR 1772 - #19631

Merged
Wes Haggard (weshaggard) merged 2 commits into
mainfrom
sync-eng/common-UpdateChangeLogBasedOnGuidelines-1772
Jul 1, 2021
Merged

Sync eng/common directory with azure-sdk-tools for PR 1772#19631
Wes Haggard (weshaggard) merged 2 commits into
mainfrom
sync-eng/common-UpdateChangeLogBasedOnGuidelines-1772

Conversation

@azure-sdk

Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1772 See eng/common workflow

Wes Haggard (weshaggard) and others added 2 commits July 1, 2021 21:35
Updates based on Azure/azure-sdk#3103

- Renamed "Key Bugs Fixed" to "Bugs Fixed"
- Renamed "Fixed" to "Other Changes"

Added a warning in validation if at lease one of the recommended
headers aren't used.
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
@check-enforcer

check-enforcer Bot commented Jul 1, 2021

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@weshaggard
Wes Haggard (weshaggard) merged commit f8425c6 into main Jul 1, 2021
@weshaggard
Wes Haggard (weshaggard) deleted the sync-eng/common-UpdateChangeLogBasedOnGuidelines-1772 branch July 1, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants