Skip to content

[ServiceBus] Fix empty coroutines/Futures with async auto lock renewer #19722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Adam Ling (yunhaoling) merged 3 commits into from
Jul 27, 2021
Merged

[ServiceBus] Fix empty coroutines/Futures with async auto lock renewer #19722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f66699e
fix async auto lock renewer empty tasks issue
yunhaoling Jul 8, 2021
7ef1e3b
Merge remote-tracking branch 'central/main' into yuling/sb/async-auto…
yunhaoling Jul 8, 2021
4dcb8d4
update changelog
yunhaoling Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/servicebus/azure-servicebus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Breaking Changes

### Bugs Fixed
- Fixed a bug that `azure.servicebus.aio.AutoLockRenewer` crashes on disposal if no messages have been registered (#19642).

### Other Changes

Expand Down
3 changes: 2 additions & 1 deletion sdk/servicebus/azure-servicebus/azure/servicebus/aio/_async_auto_lock_renewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,4 +233,5 @@ def register(
async def close(self) -> None:
"""Cease autorenewal by cancelling any remaining open lock renewal futures."""
self._shutdown.set()
await asyncio.wait(self._futures)
if self._futures:
await asyncio.wait(self._futures)
5 changes: 5 additions & 0 deletions sdk/servicebus/azure-servicebus/tests/async_tests/test_queues_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,11 @@ async def test_async_queue_by_queue_client_conn_str_receive_handler_with_autoloc
message = ServiceBusMessage("{}".format(i))
await sender.send_messages(message)

# issue https://github.com/Azure/azure-sdk-for-python/issues/19642
empty_renewer = AutoLockRenewer()
async with empty_renewer:
pass

renewer = AutoLockRenewer()
messages = []
async with sb_client.get_queue_receiver(servicebus_queue.name, max_wait_time=5, receive_mode=ServiceBusReceiveMode.PEEK_LOCK, prefetch_count=10) as receiver:
Expand Down