[QnA] Release prep - #19947
Conversation
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
Didn't look too much at docstrings, but loosk good! thanks for adding chardet
Heath Stewart (heaths)
left a comment
Heath Stewart (heaths)
left a comment
There was a problem hiding this comment.
Couple of nits that don't need to be done now.
|
|
||
| ### Features Added | ||
| * Initial release. | ||
| * Initial release - supports querying from text records and knowledge bases. |
There was a problem hiding this comment.
Good idea. I should probably do something like that.
|
|
||
| class QuestionAnsweringClient(QuestionAnsweringClientOperationsMixin): | ||
| """The language service API is a suite of natural language processing (NLP) skills built with best-in-class Microsoft machine learning algorithms. The API can be used to analyze unstructured text for tasks such as sentiment analysis, key phrase extraction, language detection and question answering. Further documentation can be found in :code:`<a href="https://docs.microsoft.com/en-us/azure/cognitive-services/text-analytics/overview">https://docs.microsoft.com/en-us/azure/cognitive-services/text-analytics/overview</a>`. | ||
| """The language service API is a suite of natural language processing (NLP) skills built with best-in-class Microsoft machine learning algorithms. The API can be used to analyze unstructured text for tasks such as sentiment analysis, key phrase extraction, language detection and question answering. Further documentation can be found in https://docs.microsoft.com/en-us/azure/cognitive-services/text-analytics/overview. |
There was a problem hiding this comment.
Nit: for review purposes, would be great - if heredoc supports it (I actually don't know) - if this was separated on multiple lines. GH doesn't make this easy to review otherwise.
There was a problem hiding this comment.
Yeah - this is in autorest, there were a couple of docs quirks I had to manually edit - but they're rendering okay.
| :paramtype question: str | ||
| :keyword records: Text records to be searched for given question. Provide either `text_query_options`, OR | ||
| individual keyword arguments. If both are provided, only the options object will be used. | ||
| :paramtype records: list[~azure.ai.language.questionanswering.models.TextRecord] |
There was a problem hiding this comment.
I take it these can't also just be strings, right? From the implementation I don't see any auto-incrementing like Text Analytics did, which I copied for .NET.
Probably don't need to worry about it now, but you might open an issue to consider for beta 2.
There was a problem hiding this comment.
Yeah I will open an issue for this.
| **kwargs # type: Any | ||
| ): | ||
| # type: (...) -> "_models.KnowledgeBaseAnswers" | ||
| """Answers the specified question using your knowledge base. |
There was a problem hiding this comment.
Shouldn't the method now be query_knowledge_base? I'm using QueryKnowledgeBase in .NET.
There was a problem hiding this comment.
hmmm that's a good point - I think this happened because my swagger readme file was redefining the operations IDs of the APIs - and so the capitalization change in the operation was ignored. I will open an issue for this.
| 'azure-core<2.0.0,>=1.16.0', | ||
| "msrest>=0.6.21" | ||
| 'msrest>=0.6.21', | ||
| 'chardet>=3.0.2,<5' |
There was a problem hiding this comment.
Nit: trailing comma makes the diff cleaner next time, like you did on line 66 above.
4 participants
No description provided.