[translation] fix samples with renamed params - #20063
Merged
Krista Pratico (kristapratico) merged 1 commit intoAug 3, 2021
Merged
Conversation
Krista Pratico (kristapratico)
requested review from
iscai-msft,
Mariana Rios Flores (maririos) and
Mo Shaban (mshaban-msft)
August 3, 2021 16:58
Mariana Rios Flores (maririos)
approved these changes
Aug 3, 2021
Mariana Rios Flores (maririos)
left a comment
Mariana Rios Flores (maririos)
left a comment
Contributor
There was a problem hiding this comment.
curious, how did you notice the difference?
is there a way the CI could check if the samples are not updated with the latest code changes?
Contributor
Author
Our vendor team opened an issue when testing samples. We do run all translation samples through CI except these ones which will depend on user input to set the filters. |
Contributor
Wow!!! Love to see that we have that extra validation :)\ Thanks for the context! |
Mo Shaban (mshaban-msft)
approved these changes
Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #20059
Missed updating these in the renaming PR.