Skip to content

[Perf] keyvault-secrets test improvements #20900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeharder merged 2 commits into from
Sep 27, 2021
Merged

[Perf] keyvault-secrets test improvements #20900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2402424
Validate vault contains 0 secrets
mikeharder Sep 24, 2021
b0404aa
Rename option from list-size to count
mikeharder Sep 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions sdk/keyvault/azure-keyvault-secrets/tests/perfstress_tests/list_secrets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,19 @@ def __init__(self, arguments):
vault_url = self.get_from_env("AZURE_KEYVAULT_URL")
self.client = SecretClient(vault_url, self.credential, **self._client_kwargs)
self.async_client = AsyncSecretClient(vault_url, self.async_credential, **self._client_kwargs)
self.secret_names = ["livekvtestlistperfsecret{}".format(i) for i in range(self.args.list_size)]
self.secret_names = ["livekvtestlistperfsecret{}".format(i) for i in range(self.args.count)]

async def global_setup(self):
"""The global setup is run only once."""
# Validate that vault contains 0 secrets (including soft-deleted secrets), since additional secrets
# (including soft-deleted) impact performance.
async for secret in self.async_client.list_properties_of_secrets():
raise Exception("KeyVault %s must contain 0 secrets (including soft-deleted) before starting perf test" \
% self.async_client.vault_url)
async for secret in self.async_client.list_deleted_secrets():
raise Exception("KeyVault %s must contain 0 secrets (including soft-deleted) before starting perf test" \
% self.async_client.vault_url)

await super().global_setup()
create = [self.async_client.set_secret(name, "secret-value") for name in self.secret_names]
await asyncio.wait(create)
Expand Down Expand Up @@ -63,5 +72,5 @@ async def run_async(self):
def add_arguments(parser):
super(ListSecretsTest, ListSecretsTest).add_arguments(parser)
parser.add_argument(
'--list-size', nargs='?', type=int, help='Number of secrets to list. Defaults to 10', default=10
'--count', nargs='?', type=int, help='Number of secrets to list. Defaults to 10', default=10
)