Skip to content

[Tables] Update cosmos and storage table name validation - #23370

Merged
lmazuel merged 20 commits into
Azure:mainfrom
YalinLi0312:yall-table-namevalidation
Mar 9, 2022
Merged

[Tables] Update cosmos and storage table name validation#23370
lmazuel merged 20 commits into
Azure:mainfrom
YalinLi0312:yall-table-namevalidation

Conversation

@YalinLi0312

@YalinLi0312 YalinLi0312 commented Mar 7, 2022

Copy link
Copy Markdown

For issue: #23106

@YalinLi0312
YalinLi0312 requested a review from annatisch as a code owner March 7, 2022 15:18
@ghost ghost added the Tables label Mar 7, 2022
@YalinLi0312 YalinLi0312 added the Client This issue points to a problem in the data-plane of the library. label Mar 7, 2022
annatisch
annatisch reviewed Mar 7, 2022
View reviewed changes
Comment thread sdk/tables/azure-data-tables/tests/_shared/asynctestcase.py Outdated
Comment thread sdk/tables/azure-data-tables/tests/_shared/testcase.py Outdated
Comment thread sdk/tables/azure-data-tables/tests/test_table_batch_cosmos.py
@annatisch

annatisch commented Mar 7, 2022

Copy link
Copy Markdown
Member

/azp run python - tables - tests

@azure-pipelines

azure-pipelines Bot commented Mar 7, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

YalinLi0312
YalinLi0312 commented Mar 8, 2022
View reviewed changes
Comment thread sdk/tables/azure-data-tables/tests/test_table_client_cosmos.py
annatisch
annatisch reviewed Mar 8, 2022
View reviewed changes
Comment thread sdk/tables/azure-data-tables/tests/test_table_cosmos.py
@check-enforcer

check-enforcer Bot commented Mar 8, 2022

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@annatisch

annatisch commented Mar 9, 2022

Copy link
Copy Markdown
Member

/azp run python - tables - tests

@azure-pipelines

azure-pipelines Bot commented Mar 9, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@annatisch

annatisch commented Mar 9, 2022

Copy link
Copy Markdown
Member

/azp run python - tables - tests

@azure-pipelines

azure-pipelines Bot commented Mar 9, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@annatisch

annatisch commented Mar 9, 2022

Copy link
Copy Markdown
Member

/azp run python - tables - tests

@azure-pipelines

azure-pipelines Bot commented Mar 9, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

lmazuel
lmazuel approved these changes Mar 9, 2022
View reviewed changes

@lmazuel lmazuel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me

@lmazuel
lmazuel merged commit 1894a95 into Azure:main Mar 9, 2022
@annatisch annatisch mentioned this pull request Mar 10, 2022
Merged
@YalinLi0312
YalinLi0312 deleted the yall-table-namevalidation branch March 10, 2022 01:15
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
Yalin Li @annatisch @rakshith91
[Tables] Update cosmos and storage table name validation (Azure#23370)
2f5a348 
* WIP

* WIP

* Add tests for storage table names

* Add tests for cosmos table names

* Run pylint

* Moved tablename validation

* Updated tests

* Revert commented out code

* Move some unit tests to live

* Fix failing tests

* Updated error code

* Updated error decoding

* Updated tests

* Some CI fixes

* Added additional error handling

* Updated release notes

* Add valid names tests

* Re-record failing tests in ci

* Mark the failed tests to run only in live

Co-authored-by: antisch <antisch@microsoft.com>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Yalin Li @annatisch @rakshith91
[Tables] Update cosmos and storage table name validation (Azure#23370)
863cbee 
* WIP

* WIP

* Add tests for storage table names

* Add tests for cosmos table names

* Run pylint

* Moved tablename validation

* Updated tests

* Revert commented out code

* Move some unit tests to live

* Fix failing tests

* Updated error code

* Updated error decoding

* Updated tests

* Some CI fixes

* Added additional error handling

* Updated release notes

* Add valid names tests

* Re-record failing tests in ci

* Mark the failed tests to run only in live

Co-authored-by: antisch <antisch@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annatisch annatisch annatisch left review comments
@lmazuel lmazuel lmazuel approved these changes

Assignees

No one assigned

Labels

Client This issue points to a problem in the data-plane of the library. Tables

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YalinLi0312 @annatisch @lmazuel