Skip to content

[Cosmos] Update cosmos codeowners - #23729

Merged
tjprescott merged 79 commits into
Azure:mainfrom
simorenoh:update-cosmos-codeowners
Apr 13, 2022
Merged

[Cosmos] Update cosmos codeowners#23729
tjprescott merged 79 commits into
Azure:mainfrom
simorenoh:update-cosmos-codeowners

Conversation

@simorenoh

@simorenoh simorenoh commented Mar 29, 2022

Copy link
Copy Markdown
Member

Adding @annatisch and @tjprescott as code owners to cosmos since they have been checking most of the big PR's already, and @JericHunter who is new to the SDK.

simorenoh and others added 30 commits August 13, 2021 13:14
* Removed some stuff

* Looking at constructors

* Updated request

* Added client close

* working client creation

Co-authored-by: simorenoh <simonmorenohe@gmail.com>
database read works, but ignored exception is returned:
Fatal error on SSL transport
NoneType has no attribute 'send' (_loop._proactor.send)
RuntimeError: Event loop is closed
Unclosed connector/ connection
Added methods needed to use async with when initializing client, but logs output "Exception ignored... Runtime Error: Event loop is closed"
missing upsert and other resources
missing read_all_items and both query methods for container class
Complete item CRUD functionality - only missing queries
Query functionality and container query methods
also fixed README and added examples_async
@jsquire
jsquire requested a review from annatisch March 29, 2022 18:06
@check-enforcer

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@tjprescott
tjprescott enabled auto-merge (squash) April 1, 2022 22:23
@simorenoh

Copy link
Copy Markdown
Member Author

/azp run python - cosmos - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@simorenoh
simorenoh requested a review from JericHunter April 6, 2022 20:14
@simorenoh

Copy link
Copy Markdown
Member Author

/check-enforcer evaluate

@tjprescott

Copy link
Copy Markdown
Member

/check-enforcer override

@tjprescott
tjprescott merged commit 23f486b into Azure:main Apr 13, 2022
@simorenoh
simorenoh deleted the update-cosmos-codeowners branch April 14, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants