Skip to content

[Cosmos] Infra: use Bicep for resource provisioning - #24198

Merged
simorenoh merged 80 commits into
Azure:mainfrom
simorenoh:cosmos-infra
Apr 27, 2022
Merged

[Cosmos] Infra: use Bicep for resource provisioning#24198
simorenoh merged 80 commits into
Azure:mainfrom
simorenoh:cosmos-infra

Conversation

@simorenoh

Copy link
Copy Markdown
Member

This PR takes care of updating the Python Cosmos SDK to utilize Bicep to provision test resources. Also has changes to the test config files to ensure these changes work and that the Cosmos test pipelines can be enabled again.

simorenoh and others added 30 commits August 13, 2021 13:14
* Removed some stuff

* Looking at constructors

* Updated request

* Added client close

* working client creation

Co-authored-by: simorenoh <simonmorenohe@gmail.com>
database read works, but ignored exception is returned:
Fatal error on SSL transport
NoneType has no attribute 'send' (_loop._proactor.send)
RuntimeError: Event loop is closed
Unclosed connector/ connection
Added methods needed to use async with when initializing client, but logs output "Exception ignored... Runtime Error: Event loop is closed"
missing upsert and other resources
missing read_all_items and both query methods for container class
Complete item CRUD functionality - only missing queries
Query functionality and container query methods
also fixed README and added examples_async
@ghost ghost added the Cosmos label Apr 26, 2022
@simorenoh

Copy link
Copy Markdown
Member Author

/azp run python - cosmos - tests

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

Comment thread sdk/cosmos/test-resources.bicep
Comment thread sdk/cosmos/test-resources.bicep
@benbp
benbp self-requested a review April 26, 2022 23:17
@benbp

benbp commented Apr 26, 2022

Copy link
Copy Markdown
Member

Some nits and considerations but LGTM.

@benbp

benbp commented Apr 26, 2022

Copy link
Copy Markdown
Member

/azp run python - cosmos - tests

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@tjprescott

Copy link
Copy Markdown
Member

@benbp does @simorenoh need to make a nominal change to the Cosmos code path to trigger the CI to run the tests?

@tjprescott

Copy link
Copy Markdown
Member

@simorenoh does this resolve the live test failures or is this a stepping stone on that path?

@simorenoh

Copy link
Copy Markdown
Member Author

@tjprescott This is very much a stepping stone - right now the tests pipeline for Python was turned off such as to not keep incurring costs the way we were doing before, and while this initial setup did deploy resources for me locally we have yet to test it on the pipeline to see if it successfully runs the tests.

I want to get this approved ASAP so I can keep iterating on this as needed to test it and get the final fixes in place as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants