Skip to content

[Eventhub] pyamqp prefetch fix #24890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
l0lawrence merged 3 commits into from
Jul 13, 2022
Merged

[Eventhub] pyamqp prefetch fix #24890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
404a1c8
prefetch fix
l0lawrence Jun 16, 2022
62b816e
adding async - sorry!
l0lawrence Jun 16, 2022
9dae751
async
l0lawrence Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/eventhub/azure-eventhub/azure/eventhub/_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def receive(self, batch=False, max_batch_size=300, max_wait_time=None):
while retried_times <= max_retries:
try:
if self._open():
self._handler.do_work(batch=self._prefetch) # type: ignore
self._handler.do_work() # type: ignore
break
except Exception as exception: # pylint: disable=broad-except
if (
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ async def _client_run_async(self, **kwargs):
:rtype: bool
"""
try:
await self._connection.listen(wait=self._socket_timeout, **kwargs)
await self._connection.listen(wait=self._socket_timeout, batch=self._link_credit, **kwargs)
except ValueError:
_logger.info("Timeout reached, closing receiver.")
self._shutdown = True
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ def _client_run(self, **kwargs):
:rtype: bool
"""
try:
self._connection.listen(wait=self._socket_timeout, **kwargs)
self._connection.listen(wait=self._socket_timeout, batch=self._link_credit, **kwargs)
Comment thread
l0lawrence marked this conversation as resolved.
except ValueError:
_logger.info("Timeout reached, closing receiver.")
self._shutdown = True
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/azure-eventhub/azure/eventhub/aio/_consumer_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ async def _receive_task(self):
while retried_times <= max_retries:
try:
await self._open()
await cast(ReceiveClientAsync, self._handler).do_work_async(batch=self._prefetch)
await cast(ReceiveClientAsync, self._handler).do_work_async()
except asyncio.CancelledError: # pylint: disable=try-except-raise
raise
except Exception as exception: # pylint: disable=broad-except
Expand Down