Skip to content

[Storage] Handling AzureNamedKeyCredential in Python SDK - #24967

Merged
vincenttran-msft merged 19 commits into
Azure:mainfrom
vincenttran-msft:vincenttran/credential_changes
Jul 22, 2022
Merged

[Storage] Handling AzureNamedKeyCredential in Python SDK#24967
vincenttran-msft merged 19 commits into
Azure:mainfrom
vincenttran-msft:vincenttran/credential_changes

Conversation

@vincenttran-msft

@vincenttran-msft vincenttran-msft commented Jun 24, 2022

Copy link
Copy Markdown
Member

Still TODO for Blob completion:

  • Propagate all the changes to other places we accept credential

TODO for full support-complete:

  • Propagate changes to other 4 packages
  • Add a test for each package

Originally raised in #24836

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 24, 2022
Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client.py Outdated
@azure-sdk

azure-sdk commented Jun 28, 2022

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob
azure-storage-file-share
azure-storage-file-datalake
azure-storage-queue

Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client.py Outdated
@vincenttran-msft
vincenttran-msft marked this pull request as ready for review June 29, 2022 18:07
@vincenttran-msft vincenttran-msft changed the title [Draft] Handling AzureNamedKeyCredential in Blob [Storage] Handling AzureNamedKeyCredential in Blob Jun 29, 2022
@vincenttran-msft vincenttran-msft changed the title [Storage] Handling AzureNamedKeyCredential in Blob [Storage] Handling AzureNamedKeyCredential in Python SDK Jun 30, 2022
Comment thread sdk/storage/azure-storage-blob-changefeed/tests/test_change_feed.py Outdated
@Azure Azure deleted a comment from check-enforcer Bot Jun 30, 2022
@vincenttran-msft

Copy link
Copy Markdown
Member Author

/azp run python - storage - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread sdk/storage/azure-storage-blob-changefeed/tests/test_change_feed.py Outdated
@vincenttran-msft

Copy link
Copy Markdown
Member Author

/azp run python - storage - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vincenttran-msft

Copy link
Copy Markdown
Member Author

/azp run python - storage - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vincenttran-msft
vincenttran-msft merged commit 1844ef9 into Azure:main Jul 22, 2022
@vincenttran-msft
vincenttran-msft deleted the vincenttran/credential_changes branch July 22, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage clients should handle AzureNamedKeyCredential as credential

3 participants