Skip to content

Update README.md - #25054

Merged
Laurent Mazuel (lmazuel) merged 1 commit into
Azure:mainfrom
mtrilbybassett:patch-4
Jul 21, 2022
Merged

Update README.md#25054
Laurent Mazuel (lmazuel) merged 1 commit into
Azure:mainfrom
mtrilbybassett:patch-4

Conversation

@mtrilbybassett

Copy link
Copy Markdown
Contributor

Corrected product taxonomy.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Corrected product taxonomy.
@ghost ghost added Container Registry customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jul 1, 2022
@ghost

Copy link
Copy Markdown

Thank you for your contribution mtrilbybassett! We will review the pull request and get back to you soon.

@tjprescott Travis Prescott (tjprescott) removed the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jul 18, 2022

@YalinLi0312 Yalin Li (YalinLi0312) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to make the folder name and the word in file names consistent?

@mtrilbybassett

Copy link
Copy Markdown
Contributor Author

Do you want to make the folder name and the word in file names consistent?

You do not have to change the folder path. The samples processor looks at the YAML header and that just needed to be modified to allow publishing.

@lmazuel

Copy link
Copy Markdown
Member

I can confirm this is correct based on azure sample link moniker:
https://docs.microsoft.com/en-us/samples/browse/?expanded=azure&products=azure-container-registry

@lmazuel
Laurent Mazuel (lmazuel) merged commit 728e558 into Azure:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants