Skip to content

[typing] Add DefaultAzureCredential to allowed types for credentials in KeyVaultClient #25144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Søren Skov Eriksen (soer7022) wants to merge 1 commit into from
Closed

[typing] Add DefaultAzureCredential to allowed types for credentials in KeyVaultClient #25144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@

if TYPE_CHECKING:
# pylint:disable=unused-import,ungrouped-imports
from typing import Any
from typing import Any, Union
from azure.core.credentials import TokenCredential
from azure.identity import DefaultAzureCredential


class ApiVersion(with_metaclass(CaseInsensitiveEnumMeta, str, Enum)):
Expand All @@ -37,7 +38,7 @@ class ApiVersion(with_metaclass(CaseInsensitiveEnumMeta, str, Enum)):

class KeyVaultClientBase(object):
def __init__(self, vault_url, credential, **kwargs):
# type: (str, TokenCredential, **Any) -> None
# type: (str, Union[TokenCredential,DefaultAzureCredential], **Any) -> None
if not credential:
raise ValueError(
"credential should be an object supporting the TokenCredential protocol, "
Expand Down