Skip to content

[Key Vault] Skip tests when vault SKU is incompatible - #25270

Merged
laiapat merged 2 commits into
Azure:mainfrom
laiapat:kv-tests-weekly
Jul 29, 2022
Merged

[Key Vault] Skip tests when vault SKU is incompatible#25270
laiapat merged 2 commits into
Azure:mainfrom
laiapat:kv-tests-weekly

Conversation

@laiapat

@laiapat laiapat commented Jul 18, 2022

Copy link
Copy Markdown
Member

Description

I recently got our weekly sovereign cloud tests running again, and test runs show that some tests -- namely, those that deal with key release -- require a premium vault SKU in order to work. Standard SKUs are used in China cloud tests, so we need to skip these when necessary.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@laiapat laiapat added KeyVault Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable test-sovereign-cloud labels Jul 18, 2022
@azure-sdk

azure-sdk commented Jul 18, 2022

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

jeesang7
jeesang7 reviewed Jul 19, 2022
View reviewed changes
Comment thread sdk/keyvault/azure-keyvault-keys/tests/test_samples_keys.py
jeesang7
jeesang7 reviewed Jul 19, 2022
View reviewed changes
Comment thread sdk/keyvault/azure-keyvault-keys/tests/test_samples_keys_async.py
YalinLi0312
YalinLi0312 reviewed Jul 19, 2022
View reviewed changes
Comment thread sdk/keyvault/azure-keyvault-keys/tests/test_keys_async.py
YalinLi0312
YalinLi0312 reviewed Jul 19, 2022
View reviewed changes
Comment thread sdk/keyvault/azure-keyvault-keys/tests/test_keys_async.py
@laiapat
laiapat requested a review from YalinLi0312 July 21, 2022 17:53
@laiapat

laiapat commented Jul 29, 2022

Copy link
Copy Markdown
Member Author

/check-enforcer evaluate

@laiapat

laiapat commented Jul 29, 2022

Copy link
Copy Markdown
Member Author

/check-enforcer override

@laiapat
laiapat merged commit eeae1f1 into Azure:main Jul 29, 2022
@laiapat
laiapat deleted the kv-tests-weekly branch July 29, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schaabs schaabs Awaiting requested review from schaabs
2 more reviewers
@jeesang7 jeesang7 jeesang7 left review comments
@YalinLi0312 YalinLi0312 YalinLi0312 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable test-sovereign-cloud

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laiapat @azure-sdk @YalinLi0312 @jeesang7