Skip to content

Create API review using generated code file by CI - #25292

Merged
praveenkuttappan merged 13 commits into
Azure:mainfrom
praveenkuttappan:feature/apiview_new_request
Jul 22, 2022
Merged

Create API review using generated code file by CI#25292
praveenkuttappan merged 13 commits into
Azure:mainfrom
praveenkuttappan:feature/apiview_new_request

Conversation

@praveenkuttappan

@praveenkuttappan praveenkuttappan commented Jul 19, 2022

Copy link
Copy Markdown
Member

This change is part of sand boxing project to skip generating API review code file within APIView server and generate automatic review using code file created by CI.

@ghost ghost added the EngSys This issue is impacting the engineering system. label Jul 19, 2022
@check-enforcer

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@praveenkuttappan

Copy link
Copy Markdown
Member Author

/azp run js - template

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-template

@praveenkuttappan
praveenkuttappan marked this pull request as ready for review July 19, 2022 20:46
@praveenkuttappan praveenkuttappan self-assigned this Jul 19, 2022
@praveenkuttappan
praveenkuttappan marked this pull request as draft July 19, 2022 22:05
Comment thread eng/pipelines/templates/steps/create-apireview.yml Outdated
Comment thread eng/pipelines/templates/steps/create-apireview.yml
Comment thread sdk/template/azure-template/azure/template/template_code.py Outdated
Comment thread eng/pipelines/templates/steps/create-apireview.yml Outdated

@scbedd scbedd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just using this PR to test the functionality? Is the goal to move the create-apireview.yml to eng/common?

OR, is this specific enough to python that it'll just stay here.

@praveenkuttappan
praveenkuttappan marked this pull request as ready for review July 20, 2022 19:46
@praveenkuttappan

Copy link
Copy Markdown
Member Author

Just using this PR to test the functionality? Is the goal to move the create-apireview.yml to eng/common?

OR, is this specific enough to python that it'll just stay here.

Eventually this will replace the files in eng/common once we have required changes completed for other languages. I am using Python as pilot language to implement sandboxing and will move this to eng/common once we are ready to move other languages to new framework.

Comment thread eng/scripts/Create-ApiReview.ps1 Outdated
Comment thread eng/scripts/Create-ApiReview.ps1
Comment thread eng/scripts/Create-ApiReview.ps1
Comment thread eng/scripts/Create-ApiReview.ps1 Outdated
Comment thread eng/scripts/Create-ApiReview.ps1 Outdated
Comment thread eng/scripts/Create-ApiReview.ps1

@weshaggard weshaggard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but the only blocking issue is to fix the script exit location.

@praveenkuttappan
praveenkuttappan merged commit c937140 into Azure:main Jul 22, 2022
@praveenkuttappan
praveenkuttappan deleted the feature/apiview_new_request branch July 22, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants