[Cosmos] updates for integrated cache PR - #25391
Merged
Merged
Conversation
ghost
added
the
simorenoh
reviewed
Jul 25, 2022
simorenoh
approved these changes
Jul 25, 2022
simorenoh
left a comment
simorenoh
left a comment
Member
There was a problem hiding this comment.
Just one comment, other than that it's good thanks Jeric!
JericHunter
marked this pull request as ready for review
July 25, 2022 20:45
JericHunter
requested review from
annatisch,
kushagraThapar,
simplynaveen20,
tjprescott and
xinlian12
as code owners
July 25, 2022 20:45
simorenoh
reviewed
Jul 28, 2022
simorenoh
approved these changes
Jul 28, 2022
simorenoh
requested changes
Jul 28, 2022
simorenoh
left a comment
simorenoh
left a comment
Member
There was a problem hiding this comment.
Removing the approval while we make changes to the README as well.
tjprescott
reviewed
Jul 28, 2022
simorenoh
reviewed
Jul 29, 2022
simorenoh
approved these changes
Jul 29, 2022
simorenoh
left a comment
simorenoh
left a comment
Member
There was a problem hiding this comment.
one minor thing but lgtm! thanks Jeric!
simorenoh
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed anything that says preview or beta or provisional, etc. Also made some changelog/readme changes.