[formrecognizer] Build model update - #25416
Merged
Merged
Conversation
ghost
added
the
catalinaperalta
commented
Jul 27, 2022
catalinaperalta
commented
Jul 27, 2022
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
catalinaperalta
force-pushed
the
buildModelUpdate
branch
from
July 27, 2022 19:05
a5eee00 to
e1267e1
Compare
catalinaperalta
marked this pull request as ready for review
July 29, 2022 00:10
catalinaperalta
requested review from
iscai-msft and
kristapratico
as code owners
July 29, 2022 00:10
catalinaperalta
requested review from
HarshaNalluru,
kinelski,
samvaity and
witemple-msft
July 29, 2022 21:01
samvaity
reviewed
Aug 1, 2022
|
|
||
| ### Breaking Changes | ||
| - Renamed `source` argument to `blob_container_url` on `begin_build_model()`. | ||
| - Changed argument order on `begin_build_model()`. `build_mode` is the first expected argument, followed by `blob_container_url`. |
Member
There was a problem hiding this comment.
curious why we made this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating
begin_build_model()to be more flexible for future design work. Also renamingsourcetoblob_container_url.