Skip to content

remove vscodecred - #25493

Merged
xiangyan99 merged 5 commits into
mainfrom
identity_remove_vscode_cred_from_dac
Aug 1, 2022
Merged

remove vscodecred#25493
xiangyan99 merged 5 commits into
mainfrom
identity_remove_vscode_cred_from_dac

Conversation

@xiangyan99

Copy link
Copy Markdown
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@xiangyan99
xiangyan99 requested a review from billwert August 1, 2022 18:55
@ghost ghost added the Azure.Identity label Aug 1, 2022
@billwert

billwert commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

I don't believe the mermaid SVG is automatically generated and you need to add it to this PR. @scottaddie ?

@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

@xiangyan99

Copy link
Copy Markdown
Member Author

/azp run python - identity - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@xiangyan99
xiangyan99 merged commit 8a03bff into main Aug 1, 2022
@xiangyan99
xiangyan99 deleted the identity_remove_vscode_cred_from_dac branch August 1, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants