Skip to content

[Tables] Drop Python 3.6 - #25566

Merged
YalinLi0312 merged 9 commits into
Azure:mainfrom
YalinLi0312:yall-tables-drop3.6
Aug 17, 2022
Merged

[Tables] Drop Python 3.6#25566
YalinLi0312 merged 9 commits into
Azure:mainfrom
YalinLi0312:yall-tables-drop3.6

Conversation

@YalinLi0312

Copy link
Copy Markdown

No description provided.

@YalinLi0312 YalinLi0312 added Client This issue points to a problem in the data-plane of the library. Tables labels Aug 4, 2022
@YalinLi0312
YalinLi0312 requested a review from annatisch as a code owner August 4, 2022 22:24
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@xiangyan99 xiangyan99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the minor version

@laiapat laiapat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the Analyze step failure, you'll just need to update _version.py to be 12.5.0. For the mindependency failures, the azure-mgmt-cosmosdb dev requirement is causing issues again... You can either update your minimum msrest version to 0.7.1, or pin your azure-mgmt-cosmosdb requirement to an earlier version, like 7.0.0

- -e ../../cosmos/azure-mgmt-cosmosdb
../../core/azure-core
../../nspkg/azure-data-nspkg
aiohttp>=3.0
azure-identity
+ azure-mgmt-cosmosdb==7.0.0

@xiangyan99, do you have an opinion on whether or not to bump the dependency?

Comment thread sdk/tables/azure-data-tables/README.md Outdated
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
@YalinLi0312

Copy link
Copy Markdown
Author

There's a similar PR for ACR which is in the same situation, same question as McCoy. @xiangyan99

@xiangyan99 xiangyan99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating _version.py is also needed. :)

@laiapat

laiapat commented Aug 16, 2022

Copy link
Copy Markdown
Member

Since this is for a new minor version, I'd recommend going ahead and bumping your minimum msrest dependency to 0.7.1 🙂

@laiapat laiapat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YalinLi0312
YalinLi0312 enabled auto-merge (squash) August 17, 2022 22:48
@YalinLi0312
YalinLi0312 merged commit 1c0d835 into Azure:main Aug 17, 2022
@YalinLi0312
YalinLi0312 deleted the yall-tables-drop3.6 branch August 17, 2022 23:29
laiapat pushed a commit to laiapat/azure-sdk-for-python that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Tables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants