[Storage] Add read to datalake StorageStreamDownloader - #25707
Merged
Conversation
jalauzon-msft
requested review from
annatisch and
vincenttran-msft
as code owners
August 15, 2022 21:16
ghost
added
the
vincenttran-msft
approved these changes
Aug 15, 2022
vincenttran-msft
left a comment
vincenttran-msft
left a comment
Member
There was a problem hiding this comment.
Thanks for getting to this! Glad you were able to double dip the benefits for all the effort you put in for Blob 😄
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
laiapat
pushed a commit
to laiapat/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #24275, this adds the
readmethod to theStorageStreamDownloaderfor datalake. This was fairly trivial since datalake's downloader just calls into blob. Added one basic test to ensure functionality but more advanced testing is handled in blob tests.