Skip to content

Handle when a specifier is not set for a targeted package within setup.py #25719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scott Beddall (scbedd) merged 2 commits into from
Aug 16, 2022
Merged

Handle when a specifier is not set for a targeted package within setup.py #25719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f15dc6a
we need to handle it when a package does not specify a specific versi…
scbedd Aug 16, 2022
b8f0e75
properly update the condition to not be a duplicate
scbedd Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/tox/create_package_and_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def build_and_discover_package(setuppy_path, dist_dir, target_setup, package_typ
addition_necessary = False

# ...do we need to install the new version? if the existing specifier matches, we're fine
if installed_pkgs[req_name] in req_specifier:
if req_specifier is not None and installed_pkgs[req_name] in req_specifier:
addition_necessary = False

if addition_necessary:
Expand Down