Skip to content

[Test Proxy] Fix parameter reference in stop_record_or_playback - #25725

Merged
laiapat merged 1 commit into
mainfrom
proxy-recordstopfix
Aug 16, 2022
Merged

[Test Proxy] Fix parameter reference in stop_record_or_playback#25725
laiapat merged 1 commit into
mainfrom
proxy-recordstopfix

Conversation

@laiapat

@laiapat laiapat commented Aug 16, 2022

Copy link
Copy Markdown
Member

Description

The test_output parameter in the test proxy infra's stop_record_or_playback method was recently changed to (more accurately) be test_variables. As part of the test tooling refactor, this name change got mismatched such that this code raises an error over an undefined test_output variable.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@laiapat laiapat added the EngSys This issue is impacting the engineering system. label Aug 16, 2022
@laiapat
laiapat requested a review from scbedd August 16, 2022 23:13
@laiapat

laiapat commented Aug 16, 2022

Copy link
Copy Markdown
Member Author

/check-enforcer override

@laiapat
laiapat merged commit 7c835fb into main Aug 16, 2022
@laiapat
laiapat deleted the proxy-recordstopfix branch August 16, 2022 23:18
laiapat added a commit to laiapat/azure-sdk-for-python that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants