Skip to content

Update proxy_startup.py - #25730

Merged
Laia Patiño (laiapat) merged 3 commits into
Azure:mainfrom
ponopono0322:auto-update-docker-image
Aug 19, 2022
Merged

Update proxy_startup.py#25730
Laia Patiño (laiapat) merged 3 commits into
Azure:mainfrom
ponopono0322:auto-update-docker-image

Conversation

@ponopono0322

Copy link
Copy Markdown
Contributor

Auto check and change docker container

Description

Fixed an issue(#22162) where docker containers were not automatically updated from eng/common/testproxy/target_version.txt file.

This is the process of checking the container named ambitious_azsdk_test_proxy and then force-deleting it if the versions do not match. This only deletes the container, not the image.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Auto check and change docker container
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 17, 2022
@ghost

Copy link
Copy Markdown

Thank you for your contribution ponopono0322! We will review the pull request and get back to you soon.

@ghost

Deleted user (ghost) commented Aug 17, 2022

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@ponopono0322

Dongwon Shin (ponopono0322) commented Aug 17, 2022

Copy link
Copy Markdown
Contributor Author

This is a scenario for the current change.

  1. Check eng/common/testproxy/target_version.txt is old. In this scenario past version is 1.0.0-dev.20220805.3
    Screen Shot 2022-08-17 at 12 02 23 PM

  2. Check docker container same as 1.

Screen Shot 2022-08-17 at 11 58 54 AM

  1. Change 1 to latest version. In this scenario latest version is 1.0.0-dev.20220810.2
    Screen Shot 2022-08-17 at 12 03 02 PM

  2. Check the image of the docker container if it has been changed well(1.0.0-dev.20220805.3 -> 1.0.0-dev.20220810.2).

Screen Shot 2022-08-17 at 12 03 38 PM

Also, azsdkengsys.azurecr.io/engsys/test-proxy image works better performance on Silicon Mac. Consider using it.
In AMD mode, it took 02:12.
Screen Shot 2022-08-17 at 12 12 57 PM

In ARM mode, it took 01:23.
Screen Shot 2022-08-17 at 12 16 17 PM
Screen Shot 2022-08-17 at 12 17 27 PM

@laiapat Laia Patiño (laiapat) added EngSys This issue is impacting the engineering system. test-enhancement labels Aug 17, 2022

@laiapat Laia Patiño (laiapat) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for opening a PR!

Comment thread tools/azure-sdk-tools/devtools_testutils/proxy_startup.py Outdated
@laiapat Laia Patiño (laiapat) linked an issue Aug 19, 2022 that may be closed by this pull request
Container will be deleted after running

@laiapat Laia Patiño (laiapat) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- thanks again!!

@laiapat
Laia Patiño (laiapat) enabled auto-merge (squash) August 19, 2022 01:02
@ponopono0322

Copy link
Copy Markdown
Contributor Author

@mccoyp Thank you. Have a nice day!

@laiapat
Laia Patiño (laiapat) merged commit 408ee52 into Azure:main Aug 19, 2022
@ponopono0322
Dongwon Shin (ponopono0322) deleted the auto-update-docker-image branch August 19, 2022 01:41
Laia Patiño (laiapat) pushed a commit to laiapat/azure-sdk-for-python that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. EngSys This issue is impacting the engineering system. test-enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test Proxy] Attempt to auto-update Docker image

2 participants