Skip to content

Catch InvalidRequirement error in CI #25787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Laia Patiño (laiapat) wants to merge 1 commit into from
Closed

Catch InvalidRequirement error in CI #25787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/devops_tasks/tox_harness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from ci_tools.parsing import ParsedSetup
from ci_tools.build import create_package

from packaging.requirements import InvalidRequirement
from pkg_resources import parse_requirements, RequirementParseError
import logging

Expand Down Expand Up @@ -210,7 +211,7 @@ def inject_custom_reqs(file, injected_packages, package_dir):
for line in f:
try:
parsed_req = [req for req in parse_requirements(line)]
except RequirementParseError as e:
except (RequirementParseError, InvalidRequirement) as e:
parsed_req = [None]
req_lines.append((line, parsed_req))

Expand Down Expand Up @@ -461,4 +462,4 @@ def prep_and_run_tox(targeted_packages, parsed_args, options_array=[]):
if not parsed_args.disablecov:
collect_tox_coverage_files(targeted_packages)

sys.exit(return_code)
sys.exit(return_code)