[conversations] Drop python 3.6 - #25792
Merged
Merged
Conversation
Change str.format() formatting of the source code to f-string formatting.
Yujin Cho (syso-jxx)
requested review from
Yalin Li (YalinLi0312),
Krista Pratico (kristapratico),
Laia Patiño (laiapat) and
Scott Schaab (schaabs)
as code owners
August 20, 2022 06:41
ghost
added
KeyVault
customer-reported
|
Thank you for your contribution syso-jxx! We will review the pull request and get back to you soon. |
|
|
Wonhyeong Seo (wonhyeongseo)
approved these changes
Aug 20, 2022
Wonhyeong Seo (wonhyeongseo)
left a comment
Wonhyeong Seo (wonhyeongseo)
left a comment
Contributor
There was a problem hiding this comment.
All keyvault related content has been reverted.
Krista Pratico (kristapratico)
left a comment
Krista Pratico (kristapratico)
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for your contribution! Once the review comment is resolved I can approve and merge your PR. :)
Contributor
|
Hello Yujin Cho (@syso-jxx), I have sent a PR that will resolve the review from the Azure team. May you please check it out? Thanks! |
fix: README.md to only warn of python2.7
Krista Pratico (kristapratico)
approved these changes
Aug 23, 2022
Krista Pratico (kristapratico)
left a comment
Krista Pratico (kristapratico)
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Thanks for the help :)
Laia Patiño (laiapat)
pushed a commit
to laiapat/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
* Improve the readability of source code Change str.format() formatting of the source code to f-string formatting. * Fix drop python 3.6 * style: revert keyvault * style: revert keyvault * style: revert keyvault * style: revert keyvault * fix: README.md to only warn of python2.7 Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #25166
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines