Skip to content

[cognitiveservices/spellcheck] Fixed typos - #25903

Merged
kristapratico merged 4 commits into
Azure:mainfrom
wonhyeongseo:language-spellcheck-cspell-coauth
Sep 1, 2022
Merged

[cognitiveservices/spellcheck] Fixed typos#25903
kristapratico merged 4 commits into
Azure:mainfrom
wonhyeongseo:language-spellcheck-cspell-coauth

Conversation

@wonhyeongseo

@wonhyeongseo wonhyeongseo commented Aug 28, 2022

Copy link
Copy Markdown
Contributor

Co-authored-by: Dohyeon Kim tnghwk0661@gmail.com

Description

fix #22596

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@wonhyeongseo @KdHyeon0661
fix: typos in language-spellcheck
7d3ca7c 
Co-authored-by: Dohyeon Kim <tnghwk0661@gmail.com>
@wonhyeongseo
wonhyeongseo requested a review from lmazuel as a code owner August 28, 2022 06:26
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 28, 2022
@ghost

ghost commented Aug 28, 2022

Copy link
Copy Markdown

Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon.

kristapratico
kristapratico reviewed Aug 30, 2022
View reviewed changes
Comment thread sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py Outdated
Comment thread sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py Outdated
kristapratico
kristapratico approved these changes Aug 31, 2022
View reviewed changes

@kristapratico kristapratico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! I will look into the CI failures - they are unrelated to your PR.

@kristapratico
kristapratico enabled auto-merge (squash) September 1, 2022 21:19
@kristapratico
kristapratico merged commit f435252 into Azure:main Sep 1, 2022
laiapat pushed a commit to laiapat/azure-sdk-for-python that referenced this pull request Sep 22, 2022
@wonhyeongseo @KdHyeon0661
@kristapratico @laiapat
[cognitiveservices/spellcheck] Fixed typos (Azure#25903)
43030f8 
* fix: typos in language-spellcheck

Co-authored-by: Dohyeon Kim <tnghwk0661@gmail.com>

* fix: revert test and add local ignore list to cspell.json

Co-authored-by: Dohyeon Kim <tnghwk0661@gmail.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel
1 more reviewer
@kristapratico kristapratico kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cognitiveservices/azure-cognitiveservices-language-spellcheck - cspell found spelling errors in source code

2 participants

@wonhyeongseo @kristapratico