Regression Runs Proxy prior to invoking tests - #26607
Merged
Merged
Conversation
…f, start the test-proxy before the test-suite. Need to avoid a situation where we're starting the wrong proxy version during regression tests
benbp
approved these changes
Oct 3, 2022
Member
Author
|
There are a couple failing regression tests, but at least we're to the real failures, versus failures of the system. Going to override and merge this. |
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We dealt with a breaking change for running the test-proxy in CI. The problem is, the regression tests are now hitting this as well because they use the engsys at the time of writing. That would mean that the
sdk-toolsstartup of the test-proxy will hit issues from these older branches.An alternative is to go in and apply the
proxy_startup.pypatch to each old tag/branch that doesn't have this adjustment. I'd rather save myself that effort. This PR is an attempt to avoid a couple dozen manual patches.