Skip to content

[EventHubs] update sync receive client ready flow #27411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swathipil merged 3 commits into from
Nov 17, 2022
Merged

[EventHubs] update sync receive client ready flow #27411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f0ac1e
update sync receive client ready flow
swathipil Nov 9, 2022
7c57f81
lint + mypy
swathipil Nov 9, 2022
7b0bcae
fix reconnect test
swathipil Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sdk/eventhub/azure-eventhub/azure/eventhub/_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,13 @@ def _open(self) -> bool:
)
self._handler = cast("ReceiveClient", self._handler)
self._handler.open(connection=conn)
while not self._handler.client_ready():
time.sleep(0.05)
self.handler_ready = True
self.handler_ready = False
self.running = True

if not self.handler_ready:
Comment thread
kashifkhan marked this conversation as resolved.
if self._handler.client_ready(): # type: ignore
self.handler_ready = True

return self.handler_ready

def receive(self, batch=False, max_batch_size=300, max_wait_time=None):
Expand Down
3 changes: 2 additions & 1 deletion sdk/eventhub/azure-eventhub/tests/livetest/synctests/test_reconnect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ def on_event_received(event):
with client:
consumer = client._create_consumer("$default", "0", "-1", on_event_received)
with consumer:
consumer._open()
while not consumer.handler_ready:
consumer._open()
time.sleep(11)

ed = EventData("Event")
Expand Down