Skip to content

[ML][Pipelines]ci: enable test_dump_distribution #27535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangchao1230 merged 1 commit into from
Nov 18, 2022
Merged

[ML][Pipelines]ci: enable test_dump_distribution #27535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sdk/ml/azure-ai-ml/tests/pipeline_job/unittests/test_pipeline_job_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,9 +1121,9 @@ def test_pipeline_job_with_environment_variables(self) -> None:
"abc": "def",
}

@pytest.mark.skip("Pipeline: discuss how to refactor _to_dict in PipelineJob & CommandComponent later.")
def test_dump_distribution(self):
from azure.ai.ml._restclient.v2021_10_01.models import TensorFlow
# pipeline level test is in test_pipeline_job_create_with_distribution_component
from azure.ai.ml import TensorFlowDistribution
from azure.ai.ml._schema.job.distribution import PyTorchDistributionSchema, TensorFlowDistributionSchema

distribution_dict = {
Expand All @@ -1132,11 +1132,12 @@ def test_dump_distribution(self):
"parameter_server_count": 0,
"worker_count": 5,
}
distribution_obj = TensorFlow.from_dict(distribution_dict)
# msrest has been removed from public interface
distribution_obj = TensorFlowDistribution(**distribution_dict)

with pytest.raises(ValidationError, match=r"Value passed is not in set \['pytorch']"):
with pytest.raises(ValidationError, match=r"Cannot dump non-PyTorchDistribution object into PyTorchDistributionSchema"):
_ = PyTorchDistributionSchema(context={"base_path": "./"}).dump(distribution_dict)
with pytest.raises(ValidationError, match=r"Value passed is not in set \['pytorch']"):
with pytest.raises(ValidationError, match=r"Cannot dump non-PyTorchDistribution object into PyTorchDistributionSchema"):
_ = PyTorchDistributionSchema(context={"base_path": "./"}).dump(distribution_obj)

after_dump_correct = TensorFlowDistributionSchema(context={"base_path": "./"}).dump(distribution_obj)
Expand Down