Skip to content

Enforce Package name approval for preview release #27573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkuttappan merged 2 commits into from
Nov 17, 2022
Merged

Enforce Package name approval for preview release #27573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bbe802
Enforce Package name approval for preview release
praveenkuttappan Nov 17, 2022
faacf71
Apply suggestions from code review
praveenkuttappan Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eng/scripts/Create-ApiReview.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ function ProcessPackage($PackageName)
}
elseif ($version.IsPrerelease)
{
# Check if package name is approved. Preview version cannot be released without package name approval
if ($respCode -eq '202' -and $pkgInfo.ReleaseStatus -and $pkgInfo.ReleaseStatus -ne "Unreleased")
{
Write-Error "Package '$PackageName' is not yet approved on APIView for preview release. Package approval for beta relase must be completed by an API approver if it was never released as a stable version."
Write-Error "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on package name approval."
exit 1
}
# Ignore API review status for prerelease version
Write-Host "Package version is not GA. Ignoring API view approval status"
}
Expand Down