[AppConfig] Fix cspell errors - #27892
Merged
Merged
Conversation
ghost
added
the
Collaborator
|
API change check API changes are not detected in this pull request. |
YalinLi0312
marked this pull request as ready for review
December 9, 2022 23:06
YalinLi0312
requested review from
danieljurek and
kristapratico
and removed request for
kristapratico
December 9, 2022 23:06
YalinLi0312
added
Client
Member
|
Why we need to re-record? |
Author
As I explained in PR description, that's because I changed file names. |
xiangyan99
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves appconfiguration/azure-appconfiguration - cspell found spelling errors in source code #22589
And also changed the test file names - that's why also has recordings updates for all test files in this PR.
I am thinking about removing file name updates to a separate PR - since the cspell fix don't have much, so just leave them there.
Let me know if you think it's easier to review when extracting them to a separate PR.