Skip to content

Flatten queue_settings properties on sweep job builder #29368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singankit merged 5 commits into from
Mar 16, 2023
Merged

Flatten queue_settings properties on sweep job builder #29368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa558ed
Flatten queue_settings properties on sweep and automl jobs
vivijay91 Mar 15, 2023
5b44380
Fix typo
vivijay91 Mar 15, 2023
e5f09ee
Fix typo
vivijay91 Mar 15, 2023
72aba81
Add flattened property to sweep on command builder
vivijay91 Mar 16, 2023
eee3744
Fix code merge
vivijay91 Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/entities/_builders/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,12 @@ def set_limits(self, *, timeout: int, **kwargs): # pylint: disable=unused-argum
self.limits = CommandJobLimits(timeout=timeout)

def set_queue_settings(self, *, job_tier: Optional[str] = None, priority: Optional[str] = None):
"""Set QueueSettings for the job.
:param job_tier: determines the job tier.
:type job_tier: str
:param priority: controls the priority on the compute.
:type priority: str
"""
if isinstance(self.queue_settings, QueueSettings):
self.queue_settings.job_tier = job_tier
self.queue_settings.priority = priority
Expand Down Expand Up @@ -422,6 +428,8 @@ def sweep(
Union[ManagedIdentityConfiguration, AmlTokenConfiguration, UserIdentityConfiguration]
] = None,
queue_settings: Optional[QueueSettings] = None,
job_tier: Optional[str] = None,
priority: Optional[str] = None,
) -> Sweep:
"""Turn the command into a sweep node with extra sweep run setting. The command component in current Command
node will be used as its trial component. A command node can sweep for multiple times, and the generated sweep
Expand Down Expand Up @@ -456,6 +464,10 @@ def sweep(
UserIdentityConfiguration]
:param queue_settings: Queue settings for the job.
:type queue_settings: QueueSettings
:param job_tier: determines the job tier.
:type job_tier: str
:param priority: controls the priority on the compute.
:type priority: str
:return: A sweep node with component from current Command node as its trial component.
:rtype: Sweep
"""
Expand All @@ -466,6 +478,13 @@ def sweep(
if search_space:
inputs_search_space.update(search_space)

if not queue_settings:
queue_settings = self.queue_settings
if job_tier is not None:
queue_settings.job_tier = job_tier
if priority is not None:
queue_settings.priority = priority

sweep_node = Sweep(
trial=copy.deepcopy(
self.component
Expand All @@ -485,7 +504,7 @@ def sweep(
experiment_name=self.experiment_name,
identity=self.identity if not identity else identity,
_from_component_func=True,
queue_settings=self.queue_settings if queue_settings is None else queue_settings,
queue_settings=queue_settings,
)
sweep_node.set_limits(
max_total_trials=max_total_trials,
Expand Down
2 changes: 1 addition & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/queue_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class QueueSettings(RestTranslatableMixin, DictMixin):
"Standard", "Premium".
:vartype job_tier: str or ~azure.mgmt.machinelearningservices.models.JobTier
:ivar priority: Controls the priority of the job on a compute.
:vartype priority: int
:vartype priority: str
"""

def __init__(
Expand Down