Skip to content

[Identity] Update async __aexit__ typing #31830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Paul Van Eck (pvaneck) merged 1 commit into from
Aug 28, 2023
Merged

[Identity] Update async __aexit__ typing #31830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/identity/azure-identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

### Other Changes

- Update typing of async credentials to match the `AsyncTokenCredential` protocol.

## 1.14.0 (2023-08-08)

### Features Added
Expand Down
9 changes: 8 additions & 1 deletion sdk/identity/azure-identity/azure/identity/aio/_internal/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# Licensed under the MIT License.
# ------------------------------------
import abc
from types import TracebackType
from typing import Optional, Type

from .aad_client import AadClient
from .decorators import wrap_exceptions
Expand All @@ -16,7 +18,12 @@ async def close(self):
async def __aenter__(self):
return self

async def __aexit__(self, *args):
async def __aexit__(
self,
exc_type: Optional[Type[BaseException]] = None,
exc_value: Optional[BaseException] = None,
traceback: Optional[TracebackType] = None,
) -> None:
await self.close()


Expand Down