[Cosmos] migrate from using unittest - #32076
Merged
Merged
Conversation
using this one as the test file
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simorenoh
marked this pull request as ready for review
October 2, 2023 20:49
simorenoh
requested review from
annatisch,
bambriz,
kushagraThapar and
xinlian12
as code owners
October 2, 2023 20:49
annatisch
reviewed
Oct 5, 2023
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
requested changes
Oct 16, 2023
kushagraThapar
left a comment
kushagraThapar
left a comment
Member
There was a problem hiding this comment.
Requesting change on the changelog update, others are just nit comments and are not blockers, thanks @simorenoh
kushagraThapar
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems as though our Cosmos async client tests are actually not running in the pipelines:
This is due to the fact that using the unit test package does not support async, and as such we have been missing coverage for a while. Most other SDKs are actually not even using unit test anymore since the new test proxy does not use it, so moving away from it in general should be the move. This PR takes care of migrating all of our existing tests to use the default pytest package, which should allow our pipelines to run async tests. This PR also fixes some tests.
I'll also be renaming the tests to have an
asyncsuffix at the end since otherwise it makes the debugging a bit rougher (from images above, you wouldn't know which is which if the time was the same.)EDIT: This is what the pipeline looks like now, with both renaming and async tests actually running:
