identity broker package

[xiangyan99]

No description provided.

[pvaneck]

I feel like we should keep code duplication to a minimum and use whatever we can from azure.identity.

How about importing InteractiveBrowserCredential from azure.identity and making that the parent class of the "extended" class and just override the things that need changing:

from azure.identity import InteractiveBrowserCredential as TraditionalInteractiveBrowserCredential


class InteractiveBrowserCredential(TraditionalInteractiveBrowserCredential):
    """Updated docstring"""

    def __init__(self, **kwargs: Any) -> None:
        self._allow_broker = kwargs.pop("allow_broker", False)
        self._parent_window_handle = kwargs.pop("parent_window_handle", None)
        self._enable_msa_passthrough = kwargs.pop("enable_msa_passthrough", False)
        super().__init__(**kwargs)

    def _get_app(self, **kwargs: Any) -> msal.ClientApplication:
        ...

    @wrap_exceptions
    def _request_token(self, *scopes: str, **kwargs: Any) -> Dict:
        ...

[xiangyan99]

I feel like we should keep code duplication to a minimum and use whatever we can from azure.identity.

How about importing InteractiveBrowserCredential from azure.identity and making that the parent class of the "extended" class and just override the things that need changing:

from azure.identity import InteractiveBrowserCredential as TraditionalInteractiveBrowserCredential


class InteractiveBrowserCredential(TraditionalInteractiveBrowserCredential):
    """Updated docstring"""

    def __init__(self, **kwargs: Any) -> None:
        self._allow_broker = kwargs.pop("allow_broker", False)
        self._parent_window_handle = kwargs.pop("parent_window_handle", None)
        self._enable_msa_passthrough = kwargs.pop("enable_msa_passthrough", False)
        super().__init__(**kwargs)

    def _get_app(self, **kwargs: Any) -> msal.ClientApplication:
        ...

    @wrap_exceptions
    def _request_token(self, *scopes: str, **kwargs: Any) -> Dict:
        ...

The problem is then we need to inherit from internal classes which we want to avoid.

[pvaneck]

The problem is then we need to inherit from internal classes which we want to avoid.

InteractiveBrowserCredential is a public credential type and having it as a parent class will majorly cut down on code duplication and make it clear that this broker browser credential is an extension of the traditional browser credential.

[pvaneck]

Noticed that the credential names changed. Was it preferable to have "Broker" in the name?

[xiangyan99]

Noticed that the credential names changed. Was it preferable to have "Broker" in the name?

I prefer to use a different name than InteractiveBrowserCredential. I will let architects decide the name.