Skip to content

remove broker support #32369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 2 commits into from
Oct 7, 2023
Merged

remove broker support #32369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce86d7a
remove broker support
xiangyan99 Oct 7, 2023
cfb5755
update
xiangyan99 Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/identity/azure-identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

### Breaking Changes

> These changes do not impact the API of stable versions such as 1.14.0.
> Only code written against a beta version such as 1.15.0b1 may be affected.
- Windows Web Account Manager (WAM) Brokered Authentication is moved into another package.
Comment thread
pvaneck marked this conversation as resolved.

### Bugs Fixed

- `ManagedIdentityCredential` will now correctly retry when the instance metadata endpoint returns a 410 response. ([#32200](https://github.com/Azure/azure-sdk-for-python/pull/32200))
Expand Down
2 changes: 0 additions & 2 deletions sdk/identity/azure-identity/azure/identity/_credentials/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ def _request_token(self, *scopes: str, **kwargs: Any) -> Dict:
timeout=self._timeout,
prompt="select_account",
port=port,
parent_window_handle=self._parent_window_handle,
enable_msa_passthrough=self._enable_msa_passthrough,
)
except socket.error as ex:
raise CredentialUnavailableError(message="Couldn't start an HTTP server.") from ex
Expand Down
7 changes: 0 additions & 7 deletions sdk/identity/azure-identity/azure/identity/_internal/msal_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ def __init__(
client_credential: Optional[Union[str, Dict]] = None,
*,
additionally_allowed_tenants: Optional[List[str]] = None,
allow_broker: Optional[bool] = None,
parent_window_handle: Optional[int] = None,
enable_msa_passthrough: Optional[bool] = None,
authority: Optional[str] = None,
disable_instance_discovery: Optional[bool] = None,
tenant_id: Optional[str] = None,
Expand All @@ -46,9 +43,6 @@ def __init__(
self._client = MsalClient(**kwargs)
self._client_credential = client_credential
self._client_id = client_id
self._allow_broker = allow_broker
self._parent_window_handle = parent_window_handle
self._enable_msa_passthrough = enable_msa_passthrough
self._enable_support_logging = enable_support_logging
self._additionally_allowed_tenants = additionally_allowed_tenants or []

Expand Down Expand Up @@ -114,7 +108,6 @@ def _get_app(self, **kwargs: Any) -> msal.ClientApplication:
token_cache=token_cache,
http_client=self._client,
instance_discovery=self._instance_discovery,
allow_broker=self._allow_broker,
enable_pii_log=self._enable_support_logging,
)

Expand Down