Skip to content

[Identity] Enable brokered auth in DAC - #40335

Merged
pvaneck merged 4 commits into
Azure:mainfrom
pvaneck:identity-dac-broker
Jul 17, 2025
Merged

[Identity] Enable brokered auth in DAC#40335
pvaneck merged 4 commits into
Azure:mainfrom
pvaneck:identity-dac-broker

Conversation

@pvaneck

@pvaneck pvaneck commented Apr 2, 2025

Copy link
Copy Markdown
Member

Description

This adds InteractiveBrowserBrokerCredential silent flow authentication to the end of the DefaultAzureCredential chain. Here, we opt to conditionally add it to the chain only if the broker package is installed.

Additional context: https://gist.github.com/christothes/f8a0dc6249261cb36a6c452717c4e932

Closes: #39966

@azure-sdk

azure-sdk commented Apr 2, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-identity

@pvaneck
pvaneck force-pushed the identity-dac-broker branch from bf20396 to e24dd7e Compare April 3, 2025 00:24
@pvaneck

pvaneck commented Apr 3, 2025

Copy link
Copy Markdown
Member Author

@xiangyan99 This is the preliminary implementation. Would be good to get your thoughts on:

  1. If we should introduce more keyword arguments for broker cred client_id/tenant_id or reuse interactive_browser_client_id and interactive_browser_tenant_id which I am currently doing.
  2. Since this is the silent flow and non-interactive, should we introduce this credential to the async DAC (even though it would be run synchronously)?

xiangyan99
xiangyan99 reviewed Apr 7, 2025
View reviewed changes
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/default.py Outdated
xiangyan99
xiangyan99 reviewed Apr 7, 2025
View reviewed changes
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/default.py Outdated
@pvaneck
pvaneck requested a review from Copilot April 7, 2025 22:31
Copilot AI reviewed Apr 7, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • sdk/identity/azure-identity/dev_requirements.txt: Language not supported

@pvaneck
pvaneck marked this pull request as ready for review April 8, 2025 00:20
@pvaneck
pvaneck requested a review from a team as a code owner April 8, 2025 00:20
xiangyan99
xiangyan99 reviewed Apr 8, 2025
View reviewed changes
Comment thread sdk/identity/azure-identity/CHANGELOG.md Outdated
xiangyan99
xiangyan99 reviewed Apr 8, 2025
View reviewed changes
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/default.py Outdated
xiangyan99
xiangyan99 reviewed Apr 8, 2025
View reviewed changes
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/default.py Outdated
@pvaneck pvaneck closed this Jun 9, 2025
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure Identity SDK Improvements Jun 9, 2025
@pvaneck pvaneck reopened this Jun 30, 2025
@pvaneck
[Identity] Enable brokered auth in DAC
670aa2d 
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck
pvaneck force-pushed the identity-dac-broker branch from 736ae6f to 670aa2d Compare July 15, 2025 21:55
pvaneck added 2 commits July 17, 2025 02:20
@pvaneck
Update broker cred to disable interactive fallback
01ebed9 
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck
Update docs
85cd3b0 
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
xiangyan99
xiangyan99 reviewed Jul 17, 2025
View reviewed changes
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/default.py Outdated
@pvaneck
Remove env name
01e5873 
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure Identity SDK Improvements Jul 17, 2025
@pvaneck
pvaneck merged commit aa29c33 into Azure:main Jul 17, 2025
20 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure Identity SDK Improvements Jul 17, 2025
@pvaneck
pvaneck deleted the identity-dac-broker branch July 17, 2025 22:02
@pvaneck
pvaneck restored the identity-dac-broker branch July 31, 2025 18:32
Copilot AI mentioned this pull request Jul 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@xiangyan99 xiangyan99 xiangyan99 approved these changes
@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity
@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity
@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity
@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity
@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity
@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity
@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees

No one assigned

Labels

Azure.Identity

Projects

Azure Identity SDK Improvements
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DefaultAzureCredential: Re-enable SSO with VSCode on Windows

4 participants

@pvaneck @azure-sdk @xiangyan99