Skip to content

[release helper] fix crash when comment is deleted #40639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 1 commit into from
Apr 22, 2025
Merged

[release helper] fix crash when comment is deleted #40639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions scripts/release_helper/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,12 @@ def new_comment_policy(self):
comments = [(comment.updated_at.timestamp(), comment.user.login) for comment in
self.issue_package.issue.get_comments()]
comments.sort()
latest_comments = comments[-1][1]
if latest_comments not in self.language_owner:
self.bot_advice.append('new comment.')
try:
latest_comments = comments[-1][1]
if latest_comments not in self.language_owner:
self.bot_advice.append('new comment.')
except Exception:
self.log('Error happened when getting latest comment.')
Comment thread
msyyc marked this conversation as resolved.

def multi_link_policy(self):
if self.has_label(MULTI_LINK_LABEL):
Expand Down