Added k8s resource attribute logic. Old tests pass. Need new tests - #41130
Merged
Conversation
Jeremy Voss (jeremydvoss)
marked this pull request as ready for review
May 27, 2025 16:38
Member
Author
|
For some reason the env var mocking is not working correctly on ubuntu. Converting to draft until it is fixed. |
Jeremy Voss (jeremydvoss)
marked this pull request as draft
May 27, 2025 18:34
Jeremy Voss (jeremydvoss)
marked this pull request as ready for review
May 27, 2025 20:59
Jeremy Voss (jeremydvoss)
force-pushed
the
aks-logic
branch
from
May 28, 2025 16:59
873e4cb to
997c200
Compare
Leighton Chen (lzchen)
approved these changes
May 28, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement spec for k8s attribute logic.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines